Attention is currently required from: V Sowmya, Kangheui Won, Reka Norman, Rizwan Qureshi, Krishna P Bhat D, Usha P.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62915 )
Change subject: mb/intel/adlrvp: Disable PM Timer for ADL-N
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62915/comment/98301c64_cd423129
PS3, Line 9: Keeping the PM timer enabled will disqualify an ADL system from entering
We already have it disabled for all brya variants including nivviks and nereid. […]
Hi Kangheui/Reka,
Yes, It'll apply to all ADL-N platforms and all the boards including ADLRVP.
@Reka, We have not disabled it for ADL-P RVP for 2 reasons.
1. We were using reference platform Brya for most of the power measurement, so ADL-P RVP was not used for s0i3 measurement.
2. if we want to use Tianocore payload, we might require PM timer enabled.
Hope this clarifies :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62915
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44651bf55df8e71a0a5a9a33ecbb8322ecd18575
Gerrit-Change-Number: 62915
Gerrit-PatchSet: 3
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Comment-Date: Thu, 07 Apr 2022 06:29:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kangheui Won
khwon@chromium.org
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Gerrit-MessageType: comment