Attention is currently required from: Anil Kumar K, Selma Bensaid, Paul Menzel, Tim Wawrzynczak, Angel Pons, Sridhar Siricilla, Bernardo Perez Priego.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58101 )
Change subject: lib/spd_bin: Fix for LPDDR5
......................................................................
Patch Set 8:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58101/comment/56d4e343_a74ac864
PS8, Line 7: Fix for LPDDR5
Please also make this a statement, and maybe use *Update*: […]
okay. will make the change.
File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/58101/comment/3f5227df_bf70c2ce
PS8, Line 27: use_ddr4_ddr5_params
Why do you think this name could be better?
Not hearing Paul back. How about changing this function like use_ddr3_params() and reverting the logic? One thing left is that:
case SPD_DRAM_LPDDR3_JEDEC:
This also returns 'true' as ddr4 and ddr5 variants. The is no perfect name for this, but use_ddr3_params() seems a bit better.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58101
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52ecf24a313d4cbdd0859c623533630c6a6c3713
Gerrit-Change-Number: 58101
Gerrit-PatchSet: 8
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Comment-Date: Tue, 02 Nov 2021 23:29:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment