Lean Sheng Tan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48544 )
Change subject: mb/intel/ehlcrb: Remove unrelated Kconfig settings ......................................................................
mb/intel/ehlcrb: Remove unrelated Kconfig settings
Update Kconfig to remove unrelated configs inheritted from JSL_RVP.
Signed-off-by: Tan, Lean Sheng lean.sheng.tan@intel.com Change-Id: Ia744b57302f7c8310c42e12cf019b7f6e7b8f9e9 --- M src/mainboard/intel/elkhartlake_crb/Kconfig 1 file changed, 0 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/48544/1
diff --git a/src/mainboard/intel/elkhartlake_crb/Kconfig b/src/mainboard/intel/elkhartlake_crb/Kconfig index 7cf727c..e8206ad 100644 --- a/src/mainboard/intel/elkhartlake_crb/Kconfig +++ b/src/mainboard/intel/elkhartlake_crb/Kconfig @@ -3,12 +3,9 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 - select DPTF_USE_EISA_HID - select DRIVERS_I2C_DA7219 select DRIVERS_I2C_HID select DRIVERS_INTEL_DPTF select DRIVERS_I2C_GENERIC - select DRIVERS_I2C_MAX98373 select DRIVERS_SPI_ACPI select DRIVERS_USB_ACPI select EC_ACPI @@ -16,7 +13,6 @@ select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select SOC_INTEL_ELKHARTLAKE - select SOC_INTEL_COMMON_BLOCK_DTT
config MAINBOARD_DIR string @@ -51,7 +47,4 @@ default 2 if INTEL_LPSS_UART_FOR_CONSOLE default 0
-config TPM_TIS_ACPI_INTERRUPT - int - default 45 # GPE0_DW1_13 (GPP_H13) endif
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48544 )
Change subject: mb/intel/ehlcrb: Remove unrelated Kconfig settings ......................................................................
Patch Set 2: Code-Review+2
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48544 )
Change subject: mb/intel/ehlcrb: Remove unrelated Kconfig settings ......................................................................
Patch Set 3: Code-Review+2
Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48544 )
Change subject: mb/intel/ehlcrb: Remove unrelated Kconfig settings ......................................................................
mb/intel/ehlcrb: Remove unrelated Kconfig settings
Update Kconfig to remove unrelated configs inheritted from JSL_RVP.
Signed-off-by: Tan, Lean Sheng lean.sheng.tan@intel.com Change-Id: Ia744b57302f7c8310c42e12cf019b7f6e7b8f9e9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48544 Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Werner Zeh werner.zeh@siemens.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/intel/elkhartlake_crb/Kconfig 1 file changed, 0 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Werner Zeh: Looks good to me, approved Frans Hendriks: Looks good to me, approved
diff --git a/src/mainboard/intel/elkhartlake_crb/Kconfig b/src/mainboard/intel/elkhartlake_crb/Kconfig index 7cf727c..e8206ad 100644 --- a/src/mainboard/intel/elkhartlake_crb/Kconfig +++ b/src/mainboard/intel/elkhartlake_crb/Kconfig @@ -3,12 +3,9 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 - select DPTF_USE_EISA_HID - select DRIVERS_I2C_DA7219 select DRIVERS_I2C_HID select DRIVERS_INTEL_DPTF select DRIVERS_I2C_GENERIC - select DRIVERS_I2C_MAX98373 select DRIVERS_SPI_ACPI select DRIVERS_USB_ACPI select EC_ACPI @@ -16,7 +13,6 @@ select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select SOC_INTEL_ELKHARTLAKE - select SOC_INTEL_COMMON_BLOCK_DTT
config MAINBOARD_DIR string @@ -51,7 +47,4 @@ default 2 if INTEL_LPSS_UART_FOR_CONSOLE default 0
-config TPM_TIS_ACPI_INTERRUPT - int - default 45 # GPE0_DW1_13 (GPP_H13) endif
-
Frans Hendriks (Code Review) -
Lean Sheng Tan (Code Review)
-
Werner Zeh (Code Review)