Attention is currently required from: Martin Roth, Mathew King, Angel Pons.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49954 )
Change subject: mb/google/guybrush: stubs to configure GPIOs
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/49954/comment/107384e5_12d22f94
PS9, Line 3: #ifndef __BASEBOARD_COMMON_VARIANTS_H__
Why add common here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49954
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5afd2df396ba41f7d25fa7ff6879b7c1f82f438c
Gerrit-Change-Number: 49954
Gerrit-PatchSet: 9
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Mathew King
mathewk@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 02 Feb 2021 04:35:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment