Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39195 )
Change subject: mb/intel/jasperlake_rvp: memory config for JSLRVP ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39195/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39195/3//COMMIT_MSG@7 PS3, Line 7: mb/intel/jasperlake_rvp: memory config for JSLRVP Please make it a statement by adding a verb (in imperative mood).
https://review.coreboot.org/c/coreboot/+/39195/3//COMMIT_MSG@8 PS3, Line 8: Please write a commit message.
https://review.coreboot.org/c/coreboot/+/39195/3/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/39195/3/src/mainboard/intel/jasperl... PS3, Line 30: {.spd_smbus_address[1] = 0xA0, : .spd_smbus_address[2] = 0xA2, : .spd_smbus_address[3] = 0xA4, : .spd_smbus_address[1] = 0xA6} Please add appropriate spaces.
https://review.coreboot.org/c/coreboot/+/39195/3/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/variants/jslrvp/memory_ddr4.c:
https://review.coreboot.org/c/coreboot/+/39195/3/src/mainboard/intel/jasperl... PS3, Line 58: */ One line, and remove the dot/period at the end.