HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39102 )
Change subject: mb/amd/inagua: Fix typos ......................................................................
mb/amd/inagua: Fix typos
Change-Id: Idff7c3ef6d8b7b0809857fbfd591851943ffc9fd Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/inagua/irq_tables.c M src/mainboard/amd/inagua/mainboard.c 2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/39102/1
diff --git a/src/mainboard/amd/inagua/irq_tables.c b/src/mainboard/amd/inagua/irq_tables.c index 1d1e81f..ad5c310 100644 --- a/src/mainboard/amd/inagua/irq_tables.c +++ b/src/mainboard/amd/inagua/irq_tables.c @@ -77,7 +77,7 @@ pirq_info = (void *)(&pirq->checksum + 1); slot_num = 0;
- /* pci bridge */ + /* PCI bridge */ write_pirq_info(pirq_info, 0, PCI_DEVFN(0x14, 4), 0x1, 0xdef8, 0x2, 0xdef8, 0x3, 0xdef8, 0x4, 0xdef8, 0, 0); diff --git a/src/mainboard/amd/inagua/mainboard.c b/src/mainboard/amd/inagua/mainboard.c index 47a267b..b868a58 100644 --- a/src/mainboard/amd/inagua/mainboard.c +++ b/src/mainboard/amd/inagua/mainboard.c @@ -20,14 +20,14 @@ static void init_gpios(void) { /** - * GPIO32 Pcie Device DeAssert for APU - * GPIO25 Pcie LAN, APU GPP2 + * GPIO32 PCIe Device DeAssert for APU + * GPIO25 PCIe LAN, APU GPP2 * GPIO02 MINIPCIE SLOT1, APU GPP3 - * GPIO50 Pcie Device DeAssert for Hudson Southbridge + * GPIO50 PCIe Device DeAssert for Hudson Southbridge * GPIO05 Express Card, SB GPP0 * GPIO26 NEC USB3.0GPPUSB, SB GPP1 * GPIO00 MINIPCIE SLOT2, SB GPP2 - * GPIO05 Pcie X1 Slot, SB GPP3 + * GPIO05 PCIe X1 Slot, SB GPP3 */
/* Multi-function pins switch to GPIO0-35, these pins are shared with
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39102
to look at the new patch set (#2).
Change subject: mb/amd/{inagua,lamar}: Fix typos ......................................................................
mb/amd/{inagua,lamar}: Fix typos
Change-Id: Idff7c3ef6d8b7b0809857fbfd591851943ffc9fd Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/inagua/irq_tables.c M src/mainboard/amd/inagua/mainboard.c M src/mainboard/amd/lamar/irq_tables.c M src/mainboard/amd/lamar/mainboard.c 4 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/39102/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39102
to look at the new patch set (#3).
Change subject: mb/amd/{inagua,lamar}: Fix typos ......................................................................
mb/amd/{inagua,lamar}: Fix typos
Change-Id: Idff7c3ef6d8b7b0809857fbfd591851943ffc9fd Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/inagua/irq_tables.c M src/mainboard/amd/inagua/mainboard.c 2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/39102/3
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39102
to look at the new patch set (#4).
Change subject: mb/amd/inagua: Fix typos ......................................................................
mb/amd/inagua: Fix typos
Change-Id: Idff7c3ef6d8b7b0809857fbfd591851943ffc9fd Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/inagua/irq_tables.c M src/mainboard/amd/inagua/mainboard.c 2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/39102/4
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39102 )
Change subject: mb/amd/inagua: Fix typos ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39102/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39102/4//COMMIT_MSG@7 PS4, Line 7: Fix typos Capitalize PCI
Hello Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39102
to look at the new patch set (#5).
Change subject: mb/amd/inagua: Capitalize PCI ......................................................................
mb/amd/inagua: Capitalize PCI
Change-Id: Idff7c3ef6d8b7b0809857fbfd591851943ffc9fd Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/inagua/irq_tables.c M src/mainboard/amd/inagua/mainboard.c 2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/39102/5
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39102 )
Change subject: mb/amd/inagua: Capitalize PCI ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39102/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39102/4//COMMIT_MSG@7 PS4, Line 7: Fix typos
Capitalize PCI
Done
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39102 )
Change subject: mb/amd/inagua: Capitalize PCI ......................................................................
Abandoned
too old
-
HAOUAS Elyes (Code Review) -
Paul Menzel (Code Review)