Attention is currently required from: Angel Pons.
Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79759?usp=email )
Change subject: nb/intel/sandybridge/raminit: Update PM_DLL_CONFIG ......................................................................
nb/intel/sandybridge/raminit: Update PM_DLL_CONFIG
A register dump between native and MRC.bin raminit showed a difference in the PM_DLL_CONFIG register. Use the same value as MRC.bin uses.
Tested on Lenovo X220: Still boots and works fine.
Change-Id: Iaf6334814c5748e5a3691a572213f433c79f382d Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/79759/1
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index 2e49675..3f5e290 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -2833,7 +2833,10 @@ }
mchbar_write32(PM_BW_LIMIT_CONFIG, 0x5f7003ff); - mchbar_write32(PM_DLL_CONFIG, 0x00073000 | ctrl->mdll_wake_delay); + if (IS_SANDY_CPU(ctrl->cpu)) + mchbar_write32(PM_DLL_CONFIG, 0x000330f0); + else + mchbar_write32(PM_DLL_CONFIG, 0x00073000 | ctrl->mdll_wake_delay);
FOR_ALL_CHANNELS { switch (ctrl->rankmap[channel]) {