[XS] Change in coreboot[main]: nb/intel/sandybridge/raminit: Drop write to BANDTIMERS_SNB

[Patrick Rudolph (Code Review)]

Attention is currently required from: Angel Pons.

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79760?usp=email )


Change subject: nb/intel/sandybridge/raminit: Drop write to BANDTIMERS_SNB
......................................................................

nb/intel/sandybridge/raminit: Drop write to BANDTIMERS_SNB

MRC.bin doesn't write BANDTIMERS_SNB register, so drop the
write. The bits written were targeting a reserved range,
so assume it didn't do anything useful.

Tested on Lenovo X220: Still boots and runs fine.

Change-Id: I920aabd60831c791188af976914553787cc0ff18
Signed-off-by: Patrick Rudolph <[e-mail]>
---
M src/northbridge/intel/sandybridge/raminit_common.c
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/79760/1

diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c
index 3f5e290..c62e1cd 100644
--- a/src/northbridge/intel/sandybridge/raminit_common.c
+++ b/src/northbridge/intel/sandybridge/raminit_common.c
@@ -2871,7 +2871,6 @@
 
 	mchbar_setbits32(MC_INIT_STATE_G, 1 << 0);
 	mchbar_setbits32(MC_INIT_STATE_G, 1 << 7);
-	mchbar_write32(BANDTIMERS_SNB, 0xfa);
 
 	/* Find a populated channel */
 	FOR_ALL_POPULATED_CHANNELS

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/79760?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I920aabd60831c791188af976914553787cc0ff18
Gerrit-Change-Number: 79760
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-MessageType: newchange