Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40696 )
Change subject: src/cpu/x86/16bit/entry16.inc: Fix typos ......................................................................
src/cpu/x86/16bit/entry16.inc: Fix typos
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I89d4d9d3a4a8a7545921dabb50f33035a090ecda --- M src/cpu/x86/16bit/entry16.inc 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/40696/1
diff --git a/src/cpu/x86/16bit/entry16.inc b/src/cpu/x86/16bit/entry16.inc index f7fd416..c71acb0 100644 --- a/src/cpu/x86/16bit/entry16.inc +++ b/src/cpu/x86/16bit/entry16.inc @@ -71,13 +71,13 @@ * * One way to work around this is to have the linker do the * math instead of the assembler. This solves the very - * pratical problem of being able to write code that can + * practical problem of being able to write code that can * be relocated. * * An lgdt call before we have memory enabled cannot be * position independent, as we cannot execute a call * instruction to get our current instruction pointer. - * So while this code is relocateable it isn't arbitrarily + * So while this code is relocatable it isn't arbitrarily * relocatable. * * The criteria for relocation have been relaxed to their
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40696 )
Change subject: src/cpu/x86/16bit/entry16.inc: Fix typos ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40696 )
Change subject: src/cpu/x86/16bit/entry16.inc: Fix typos ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40696 )
Change subject: src/cpu/x86/16bit/entry16.inc: Fix typos ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40696/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40696/1//COMMIT_MSG@7 PS1, Line 7: src/cpu/x86/16bit/entry16.inc: Fix typos Fix typos in comment
Hello Elyes HAOUAS, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Marshall Dawson, Paul Menzel, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40696
to look at the new patch set (#2).
Change subject: cpu/x86/16bit/entry16.inc: Fix typos in comment ......................................................................
cpu/x86/16bit/entry16.inc: Fix typos in comment
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I89d4d9d3a4a8a7545921dabb50f33035a090ecda --- M src/cpu/x86/16bit/entry16.inc 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/40696/2
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40696 )
Change subject: cpu/x86/16bit/entry16.inc: Fix typos in comment ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40696/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40696/1//COMMIT_MSG@7 PS1, Line 7: src/cpu/x86/16bit/entry16.inc: Fix typos
Fix typos in comment
Done
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40696 )
Change subject: cpu/x86/16bit/entry16.inc: Fix typos in comment ......................................................................
Patch Set 2: Code-Review+2
Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40696 )
Change subject: cpu/x86/16bit/entry16.inc: Fix typos in comment ......................................................................
cpu/x86/16bit/entry16.inc: Fix typos in comment
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I89d4d9d3a4a8a7545921dabb50f33035a090ecda Reviewed-on: https://review.coreboot.org/c/coreboot/+/40696 Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/cpu/x86/16bit/entry16.inc 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Aaron Durbin: Looks good to me, approved Furquan Shaikh: Looks good to me, approved Marshall Dawson: Looks good to me, approved
diff --git a/src/cpu/x86/16bit/entry16.inc b/src/cpu/x86/16bit/entry16.inc index f7fd416..c71acb0 100644 --- a/src/cpu/x86/16bit/entry16.inc +++ b/src/cpu/x86/16bit/entry16.inc @@ -71,13 +71,13 @@ * * One way to work around this is to have the linker do the * math instead of the assembler. This solves the very - * pratical problem of being able to write code that can + * practical problem of being able to write code that can * be relocated. * * An lgdt call before we have memory enabled cannot be * position independent, as we cannot execute a call * instruction to get our current instruction pointer. - * So while this code is relocateable it isn't arbitrarily + * So while this code is relocatable it isn't arbitrarily * relocatable. * * The criteria for relocation have been relaxed to their
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)
-
Marshall Dawson (Code Review)
-
Paul Menzel (Code Review)
-
Raul Rangel (Code Review)