Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33861
Change subject: util/ifdtool: Enable -Wmissing-prototypes ......................................................................
util/ifdtool: Enable -Wmissing-prototypes
Change-Id: Idc31144024f785a42cbad78bf2c965d08dcc5178 Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M util/ifdtool/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/33861/1
diff --git a/util/ifdtool/Makefile b/util/ifdtool/Makefile index e1188b2..4cddfc5 100644 --- a/util/ifdtool/Makefile +++ b/util/ifdtool/Makefile @@ -18,7 +18,7 @@ CC = gcc INSTALL = /usr/bin/env install PREFIX = /usr/local -CFLAGS = -O2 -g -Wall -W -Werror -I../../src/commonlib/include +CFLAGS = -O2 -g -Wall -W -Wmissing-prototypes -Werror -I../../src/commonlib/include LDFLAGS =
OBJS = ifdtool.o
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33861 )
Change subject: util/ifdtool: Enable -Wmissing-prototypes ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33861 )
Change subject: util/ifdtool: Enable -Wmissing-prototypes ......................................................................
util/ifdtool: Enable -Wmissing-prototypes
Change-Id: Idc31144024f785a42cbad78bf2c965d08dcc5178 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Reviewed-on: https://review.coreboot.org/c/coreboot/+/33861 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M util/ifdtool/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/util/ifdtool/Makefile b/util/ifdtool/Makefile index e1188b2..4cddfc5 100644 --- a/util/ifdtool/Makefile +++ b/util/ifdtool/Makefile @@ -18,7 +18,7 @@ CC = gcc INSTALL = /usr/bin/env install PREFIX = /usr/local -CFLAGS = -O2 -g -Wall -W -Werror -I../../src/commonlib/include +CFLAGS = -O2 -g -Wall -W -Wmissing-prototypes -Werror -I../../src/commonlib/include LDFLAGS =
OBJS = ifdtool.o
-
Jacob Garber (Code Review) -
Martin Roth (Code Review)