Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37235 )
Change subject: amdfam10: Clean leftover prototypes ......................................................................
amdfam10: Clean leftover prototypes
Change-Id: Ic3278cb1148c34284aba59f6f588713b683ca90b Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/include/cpu/amd/car.h 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/37235/1
diff --git a/src/include/cpu/amd/car.h b/src/include/cpu/amd/car.h index 359fa6b..e4dd142 100644 --- a/src/include/cpu/amd/car.h +++ b/src/include/cpu/amd/car.h @@ -4,10 +4,6 @@ #include <arch/cpu.h>
void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx); -asmlinkage void *post_cache_as_ram(void); -asmlinkage void cache_as_ram_new_stack(void); - -void disable_cache_as_ram(void);
void asmlinkage early_all_cores(void);
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37235 )
Change subject: amdfam10: Clean leftover prototypes ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37235/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37235/1//COMMIT_MSG@7 PS1, Line 7: amdfam10: Clean leftover prototypes It should be something like cpu/amd/car instead of amdfam10, I think. The change was not related to amdfam10 only
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37235 )
Change subject: amdfam10: Clean leftover prototypes ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37235/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37235/1//COMMIT_MSG@7 PS1, Line 7: amdfam10: Clean leftover prototypes
It should be something like cpu/amd/car instead of amdfam10, I think. […]
What other platform? No need to mention geodes here any more.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37235 )
Change subject: amdfam10: Clean leftover prototypes ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37235/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37235/1//COMMIT_MSG@7 PS1, Line 7: amdfam10: Clean leftover prototypes
What other platform? No need to mention geodes here any more.
NVM, I have mistaken it with cache_as_ram_main for agesa...
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37235 )
Change subject: amdfam10: Clean leftover prototypes ......................................................................
Patch Set 1: Code-Review+2
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37235 )
Change subject: amdfam10: Clean leftover prototypes ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37235 )
Change subject: amdfam10: Clean leftover prototypes ......................................................................
amdfam10: Clean leftover prototypes
Change-Id: Ic3278cb1148c34284aba59f6f588713b683ca90b Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37235 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Michał Żygowski michal.zygowski@3mdeb.com --- M src/include/cpu/amd/car.h 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Michał Żygowski: Looks good to me, approved
diff --git a/src/include/cpu/amd/car.h b/src/include/cpu/amd/car.h index 359fa6b..e4dd142 100644 --- a/src/include/cpu/amd/car.h +++ b/src/include/cpu/amd/car.h @@ -4,10 +4,6 @@ #include <arch/cpu.h>
void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx); -asmlinkage void *post_cache_as_ram(void); -asmlinkage void cache_as_ram_new_stack(void); - -void disable_cache_as_ram(void);
void asmlinkage early_all_cores(void);