Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18526 )
Change subject: binaryPI: Drop CAR teardown without POSTCAR_STAGE ......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/coreboot/+/18526/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/18526/8//COMMIT_MSG@11 PS8, Line 11: POSTCAR_STAGE now.
I need to add references to changes and discussions. This is really a revert for the gcccar. […]
Done
https://review.coreboot.org/c/coreboot/+/18526/8/src/drivers/amd/agesa/cache... File src/drivers/amd/agesa/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/18526/8/src/drivers/amd/agesa/cache... PS8, Line 108: * calling to chipset_teardown_car below.
stale comment
Done
https://review.coreboot.org/c/coreboot/+/18526/8/src/drivers/amd/agesa/exit_... File src/drivers/amd/agesa/exit_car.S:
https://review.coreboot.org/c/coreboot/+/18526/8/src/drivers/amd/agesa/exit_... PS8, Line 32: /* enable cache */ : movl %cr0, %eax : andl $(~(CR0_CD | CR0_NW)), %eax : movl %eax, %cr0
It will be followup if we find this is redunant now. […]
Ack
-
Kyösti Mälkki (Code Review)