Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/58340 )
Change subject: soc/amd/common: move configure_espi_with_mb_hook implementation ......................................................................
soc/amd/common: move configure_espi_with_mb_hook implementation
Move the actual implementation of configure_espi_with_mb_hook out of the header file and into the espi_util.c file.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I1106e69a52bf329a41e8e12fd09db846310b102a --- M src/soc/amd/common/block/include/amdblocks/espi.h M src/soc/amd/common/block/lpc/espi_util.c 2 files changed, 8 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/58340/1
diff --git a/src/soc/amd/common/block/include/amdblocks/espi.h b/src/soc/amd/common/block/include/amdblocks/espi.h index e12b1b8..f9e2570 100644 --- a/src/soc/amd/common/block/include/amdblocks/espi.h +++ b/src/soc/amd/common/block/include/amdblocks/espi.h @@ -132,10 +132,6 @@ void mb_set_up_early_espi(void);
/* Setup eSPI with any mainboard specific initialization. */ -static inline void configure_espi_with_mb_hook(void) -{ - mb_set_up_early_espi(); - espi_setup(); -} +void configure_espi_with_mb_hook(void);
#endif /* AMD_BLOCK_ESPI_H */ diff --git a/src/soc/amd/common/block/lpc/espi_util.c b/src/soc/amd/common/block/lpc/espi_util.c index ebc8f45..4eb700b 100644 --- a/src/soc/amd/common/block/lpc/espi_util.c +++ b/src/soc/amd/common/block/lpc/espi_util.c @@ -1053,3 +1053,10 @@
return 0; } + +/* Setup eSPI with any mainboard specific initialization. */ +void configure_espi_with_mb_hook(void) +{ + mb_set_up_early_espi(); + espi_setup(); +}