Attention is currently required from: Raul Rangel, Marshall Dawson, Justin Frodsham.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51197 )
Change subject: [WIP] vc/amd/fsp/cezanne: add platform_descriptors.h
......................................................................
Patch Set 8:
(4 comments)
File src/vendorcode/amd/fsp/cezanne/platform_descriptors.h:
https://review.coreboot.org/c/coreboot/+/51197/comment/4dfb85f7_3b7085c1
PS7, Line 15: typedef
Do we need to use typedefs?
no. that's just how it's done on the fsp/agesa side
https://review.coreboot.org/c/coreboot/+/51197/comment/bb6effb8_6389c327
PS7, Line 78: AUX1
good idea
Done
https://review.coreboot.org/c/coreboot/+/51197/comment/50cbe5a8_fa7835c6
PS7, Line 89: HDP1
Same
Done
https://review.coreboot.org/c/coreboot/+/51197/comment/3a5eb4cb_e699f983
PS7, Line 100: DP
I would also prefix these since enums get added to the global namespace.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51197
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib16f133b270c99c6e060e5bd0c156cbb03293474
Gerrit-Change-Number: 51197
Gerrit-PatchSet: 8
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@protonmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Justin Frodsham
justin.frodsham@protonmail.com
Gerrit-Comment-Date: Tue, 30 Mar 2021 21:39:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment