Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38089 )
Change subject: HP sandy/ivy laptops: Sort Kconfig `select` lines ......................................................................
HP sandy/ivy laptops: Sort Kconfig `select` lines
Sort them alphabetically.
Change-Id: Ica7462d28d2aad184b6545db46547a01bc2a8ccb Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/hp/2570p/Kconfig M src/mainboard/hp/2760p/Kconfig M src/mainboard/hp/8460p/Kconfig M src/mainboard/hp/8470p/Kconfig M src/mainboard/hp/8770w/Kconfig M src/mainboard/hp/folio_9470m/Kconfig M src/mainboard/hp/revolve_810_g1/Kconfig 7 files changed, 50 insertions(+), 50 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/38089/1
diff --git a/src/mainboard/hp/2570p/Kconfig b/src/mainboard/hp/2570p/Kconfig index a014b0c..f7d2781 100644 --- a/src/mainboard/hp/2570p/Kconfig +++ b/src/mainboard/hp/2570p/Kconfig @@ -18,20 +18,20 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select EC_HP_KBC1126 + select GFX_GMA_INTERNAL_IS_LVDS select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select HAVE_CMOS_DEFAULT + select HAVE_OPTION_TABLE select INTEL_INT15 + select MAINBOARD_HAS_LIBGFXINIT + select MAINBOARD_USES_IFD_GBE_REGION select NORTHBRIDGE_INTEL_SANDYBRIDGE select SERIRQ_CONTINUOUS_MODE select SOUTHBRIDGE_INTEL_C216 select SYSTEM_TYPE_LAPTOP select USE_NATIVE_RAMINIT - select EC_HP_KBC1126 - select MAINBOARD_HAS_LIBGFXINIT - select GFX_GMA_INTERNAL_IS_LVDS - select HAVE_OPTION_TABLE - select HAVE_CMOS_DEFAULT - select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR string diff --git a/src/mainboard/hp/2760p/Kconfig b/src/mainboard/hp/2760p/Kconfig index 935064c..bdef0c7 100644 --- a/src/mainboard/hp/2760p/Kconfig +++ b/src/mainboard/hp/2760p/Kconfig @@ -18,20 +18,20 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_8192 + select EC_HP_KBC1126 + select GFX_GMA_INTERNAL_IS_LVDS select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select HAVE_CMOS_DEFAULT + select HAVE_OPTION_TABLE select INTEL_INT15 + select MAINBOARD_HAS_LIBGFXINIT + select MAINBOARD_USES_IFD_GBE_REGION select NORTHBRIDGE_INTEL_SANDYBRIDGE select SERIRQ_CONTINUOUS_MODE select SOUTHBRIDGE_INTEL_BD82X6X select SYSTEM_TYPE_LAPTOP select USE_NATIVE_RAMINIT - select EC_HP_KBC1126 - select MAINBOARD_HAS_LIBGFXINIT - select GFX_GMA_INTERNAL_IS_LVDS - select HAVE_OPTION_TABLE - select HAVE_CMOS_DEFAULT - select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR string diff --git a/src/mainboard/hp/8460p/Kconfig b/src/mainboard/hp/8460p/Kconfig index 08e21fd..a1497c3 100644 --- a/src/mainboard/hp/8460p/Kconfig +++ b/src/mainboard/hp/8460p/Kconfig @@ -18,23 +18,23 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_8192 + select EC_HP_KBC1126 + select GFX_GMA_INTERNAL_IS_LVDS select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select HAVE_CMOS_DEFAULT + select HAVE_OPTION_TABLE select INTEL_INT15 - select NORTHBRIDGE_INTEL_SANDYBRIDGE - select SERIRQ_CONTINUOUS_MODE - select SOUTHBRIDGE_INTEL_BD82X6X - select SYSTEM_TYPE_LAPTOP - select USE_NATIVE_RAMINIT select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_TPM1 - select GFX_GMA_INTERNAL_IS_LVDS - select EC_HP_KBC1126 - select SUPERIO_SMSC_LPC47N217 - select HAVE_OPTION_TABLE - select HAVE_CMOS_DEFAULT select MAINBOARD_USES_IFD_GBE_REGION + select NORTHBRIDGE_INTEL_SANDYBRIDGE + select SERIRQ_CONTINUOUS_MODE + select SOUTHBRIDGE_INTEL_BD82X6X + select SUPERIO_SMSC_LPC47N217 + select SYSTEM_TYPE_LAPTOP + select USE_NATIVE_RAMINIT
config MAINBOARD_DIR string diff --git a/src/mainboard/hp/8470p/Kconfig b/src/mainboard/hp/8470p/Kconfig index e084d00..24bedec 100644 --- a/src/mainboard/hp/8470p/Kconfig +++ b/src/mainboard/hp/8470p/Kconfig @@ -18,21 +18,21 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select EC_HP_KBC1126 + select GFX_GMA_INTERNAL_IS_LVDS select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select HAVE_CMOS_DEFAULT + select HAVE_OPTION_TABLE select INTEL_INT15 + select MAINBOARD_HAS_LIBGFXINIT + select MAINBOARD_USES_IFD_GBE_REGION select NORTHBRIDGE_INTEL_SANDYBRIDGE select SERIRQ_CONTINUOUS_MODE select SOUTHBRIDGE_INTEL_C216 + select SUPERIO_SMSC_LPC47N217 select SYSTEM_TYPE_LAPTOP select USE_NATIVE_RAMINIT - select MAINBOARD_HAS_LIBGFXINIT - select GFX_GMA_INTERNAL_IS_LVDS - select EC_HP_KBC1126 - select SUPERIO_SMSC_LPC47N217 - select HAVE_OPTION_TABLE - select HAVE_CMOS_DEFAULT - select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR string diff --git a/src/mainboard/hp/8770w/Kconfig b/src/mainboard/hp/8770w/Kconfig index 0459208..a80860c 100644 --- a/src/mainboard/hp/8770w/Kconfig +++ b/src/mainboard/hp/8770w/Kconfig @@ -19,18 +19,18 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select EC_HP_KBC1126 select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select HAVE_CMOS_DEFAULT + select HAVE_OPTION_TABLE + select MAINBOARD_USES_IFD_GBE_REGION select NORTHBRIDGE_INTEL_SANDYBRIDGE select SERIRQ_CONTINUOUS_MODE select SOUTHBRIDGE_INTEL_C216 + select SUPERIO_SMSC_LPC47N217 select SYSTEM_TYPE_LAPTOP select USE_NATIVE_RAMINIT - select EC_HP_KBC1126 - select SUPERIO_SMSC_LPC47N217 - select HAVE_OPTION_TABLE - select HAVE_CMOS_DEFAULT - select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR string diff --git a/src/mainboard/hp/folio_9470m/Kconfig b/src/mainboard/hp/folio_9470m/Kconfig index 634cb92..b40ca25 100644 --- a/src/mainboard/hp/folio_9470m/Kconfig +++ b/src/mainboard/hp/folio_9470m/Kconfig @@ -4,21 +4,21 @@ def_bool y select BOARD_ROMSIZE_KB_16384 select EC_HP_KBC1126 + select GFX_GMA_INTERNAL_IS_LVDS select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select HAVE_CMOS_DEFAULT + select HAVE_OPTION_TABLE + select INTEL_GMA_HAVE_VBT select INTEL_INT15 + select MAINBOARD_HAS_LIBGFXINIT + select MAINBOARD_HAS_LPC_TPM + select MAINBOARD_USES_IFD_GBE_REGION select NORTHBRIDGE_INTEL_SANDYBRIDGE select SERIRQ_CONTINUOUS_MODE select SOUTHBRIDGE_INTEL_C216 select SYSTEM_TYPE_LAPTOP select USE_NATIVE_RAMINIT - select MAINBOARD_HAS_LPC_TPM - select HAVE_OPTION_TABLE - select HAVE_CMOS_DEFAULT - select MAINBOARD_HAS_LIBGFXINIT - select GFX_GMA_INTERNAL_IS_LVDS - select MAINBOARD_USES_IFD_GBE_REGION - select INTEL_GMA_HAVE_VBT
config MAINBOARD_DIR string diff --git a/src/mainboard/hp/revolve_810_g1/Kconfig b/src/mainboard/hp/revolve_810_g1/Kconfig index 3bcfc63..da27242 100644 --- a/src/mainboard/hp/revolve_810_g1/Kconfig +++ b/src/mainboard/hp/revolve_810_g1/Kconfig @@ -4,23 +4,23 @@ def_bool y select BOARD_ROMSIZE_KB_16384 select EC_HP_KBC1126 + select GENERIC_SPD_BIN + select GFX_GMA_INTERNAL_IS_LVDS select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select HAVE_CMOS_DEFAULT + select HAVE_OPTION_TABLE select INTEL_INT15 + select INTEL_GMA_HAVE_VBT + select MAINBOARD_USES_IFD_GBE_REGION + select MAINBOARD_HAS_LIBGFXINIT + select MAINBOARD_HAS_LPC_TPM + select MAINBOARD_HAS_TPM1 select NORTHBRIDGE_INTEL_SANDYBRIDGE select SERIRQ_CONTINUOUS_MODE select SOUTHBRIDGE_INTEL_C216 select SYSTEM_TYPE_LAPTOP select USE_NATIVE_RAMINIT - select MAINBOARD_HAS_LPC_TPM - select MAINBOARD_HAS_TPM1 - select GENERIC_SPD_BIN - select HAVE_OPTION_TABLE - select HAVE_CMOS_DEFAULT - select MAINBOARD_HAS_LIBGFXINIT - select GFX_GMA_INTERNAL_IS_LVDS - select MAINBOARD_USES_IFD_GBE_REGION - select INTEL_GMA_HAVE_VBT
config MAINBOARD_DIR string
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38089 )
Change subject: HP sandy/ivy laptops: Sort Kconfig `select` lines ......................................................................
Patch Set 1: Code-Review+2
I would prefer grouping by topic over fully alphabetically, though.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38089 )
Change subject: HP sandy/ivy laptops: Sort Kconfig `select` lines ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+2
I would prefer grouping by topic over fully alphabetically, though.
The sorting was to ease merging of the various variants together. Then, when adding variants, I just had to go through the original Kconfig selects and delete the ones in the variant-enabled Kconfig. Then, the result goes into Kconfig.name as-is.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38089 )
Change subject: HP sandy/ivy laptops: Sort Kconfig `select` lines ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1: Code-Review+2
I would prefer grouping by topic over fully alphabetically, though.
The sorting was to ease merging of the various variants together. Then, when adding variants, I just had to go through the original Kconfig selects and delete the ones in the variant-enabled Kconfig. Then, the result goes into Kconfig.name as-is.
Yep, it's probably easier to adapt in a later patch.
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38089 )
Change subject: HP sandy/ivy laptops: Sort Kconfig `select` lines ......................................................................
HP sandy/ivy laptops: Sort Kconfig `select` lines
Sort them alphabetically.
Change-Id: Ica7462d28d2aad184b6545db46547a01bc2a8ccb Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38089 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/hp/2570p/Kconfig M src/mainboard/hp/2760p/Kconfig M src/mainboard/hp/8460p/Kconfig M src/mainboard/hp/8470p/Kconfig M src/mainboard/hp/8770w/Kconfig M src/mainboard/hp/folio_9470m/Kconfig M src/mainboard/hp/revolve_810_g1/Kconfig 7 files changed, 50 insertions(+), 50 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/hp/2570p/Kconfig b/src/mainboard/hp/2570p/Kconfig index a014b0c..f7d2781 100644 --- a/src/mainboard/hp/2570p/Kconfig +++ b/src/mainboard/hp/2570p/Kconfig @@ -18,20 +18,20 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select EC_HP_KBC1126 + select GFX_GMA_INTERNAL_IS_LVDS select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select HAVE_CMOS_DEFAULT + select HAVE_OPTION_TABLE select INTEL_INT15 + select MAINBOARD_HAS_LIBGFXINIT + select MAINBOARD_USES_IFD_GBE_REGION select NORTHBRIDGE_INTEL_SANDYBRIDGE select SERIRQ_CONTINUOUS_MODE select SOUTHBRIDGE_INTEL_C216 select SYSTEM_TYPE_LAPTOP select USE_NATIVE_RAMINIT - select EC_HP_KBC1126 - select MAINBOARD_HAS_LIBGFXINIT - select GFX_GMA_INTERNAL_IS_LVDS - select HAVE_OPTION_TABLE - select HAVE_CMOS_DEFAULT - select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR string diff --git a/src/mainboard/hp/2760p/Kconfig b/src/mainboard/hp/2760p/Kconfig index 935064c..bdef0c7 100644 --- a/src/mainboard/hp/2760p/Kconfig +++ b/src/mainboard/hp/2760p/Kconfig @@ -18,20 +18,20 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_8192 + select EC_HP_KBC1126 + select GFX_GMA_INTERNAL_IS_LVDS select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select HAVE_CMOS_DEFAULT + select HAVE_OPTION_TABLE select INTEL_INT15 + select MAINBOARD_HAS_LIBGFXINIT + select MAINBOARD_USES_IFD_GBE_REGION select NORTHBRIDGE_INTEL_SANDYBRIDGE select SERIRQ_CONTINUOUS_MODE select SOUTHBRIDGE_INTEL_BD82X6X select SYSTEM_TYPE_LAPTOP select USE_NATIVE_RAMINIT - select EC_HP_KBC1126 - select MAINBOARD_HAS_LIBGFXINIT - select GFX_GMA_INTERNAL_IS_LVDS - select HAVE_OPTION_TABLE - select HAVE_CMOS_DEFAULT - select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR string diff --git a/src/mainboard/hp/8460p/Kconfig b/src/mainboard/hp/8460p/Kconfig index 08e21fd..a1497c3 100644 --- a/src/mainboard/hp/8460p/Kconfig +++ b/src/mainboard/hp/8460p/Kconfig @@ -18,23 +18,23 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_8192 + select EC_HP_KBC1126 + select GFX_GMA_INTERNAL_IS_LVDS select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select HAVE_CMOS_DEFAULT + select HAVE_OPTION_TABLE select INTEL_INT15 - select NORTHBRIDGE_INTEL_SANDYBRIDGE - select SERIRQ_CONTINUOUS_MODE - select SOUTHBRIDGE_INTEL_BD82X6X - select SYSTEM_TYPE_LAPTOP - select USE_NATIVE_RAMINIT select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_TPM1 - select GFX_GMA_INTERNAL_IS_LVDS - select EC_HP_KBC1126 - select SUPERIO_SMSC_LPC47N217 - select HAVE_OPTION_TABLE - select HAVE_CMOS_DEFAULT select MAINBOARD_USES_IFD_GBE_REGION + select NORTHBRIDGE_INTEL_SANDYBRIDGE + select SERIRQ_CONTINUOUS_MODE + select SOUTHBRIDGE_INTEL_BD82X6X + select SUPERIO_SMSC_LPC47N217 + select SYSTEM_TYPE_LAPTOP + select USE_NATIVE_RAMINIT
config MAINBOARD_DIR string diff --git a/src/mainboard/hp/8470p/Kconfig b/src/mainboard/hp/8470p/Kconfig index e084d00..24bedec 100644 --- a/src/mainboard/hp/8470p/Kconfig +++ b/src/mainboard/hp/8470p/Kconfig @@ -18,21 +18,21 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select EC_HP_KBC1126 + select GFX_GMA_INTERNAL_IS_LVDS select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select HAVE_CMOS_DEFAULT + select HAVE_OPTION_TABLE select INTEL_INT15 + select MAINBOARD_HAS_LIBGFXINIT + select MAINBOARD_USES_IFD_GBE_REGION select NORTHBRIDGE_INTEL_SANDYBRIDGE select SERIRQ_CONTINUOUS_MODE select SOUTHBRIDGE_INTEL_C216 + select SUPERIO_SMSC_LPC47N217 select SYSTEM_TYPE_LAPTOP select USE_NATIVE_RAMINIT - select MAINBOARD_HAS_LIBGFXINIT - select GFX_GMA_INTERNAL_IS_LVDS - select EC_HP_KBC1126 - select SUPERIO_SMSC_LPC47N217 - select HAVE_OPTION_TABLE - select HAVE_CMOS_DEFAULT - select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR string diff --git a/src/mainboard/hp/8770w/Kconfig b/src/mainboard/hp/8770w/Kconfig index 0459208..a80860c 100644 --- a/src/mainboard/hp/8770w/Kconfig +++ b/src/mainboard/hp/8770w/Kconfig @@ -19,18 +19,18 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select EC_HP_KBC1126 select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select HAVE_CMOS_DEFAULT + select HAVE_OPTION_TABLE + select MAINBOARD_USES_IFD_GBE_REGION select NORTHBRIDGE_INTEL_SANDYBRIDGE select SERIRQ_CONTINUOUS_MODE select SOUTHBRIDGE_INTEL_C216 + select SUPERIO_SMSC_LPC47N217 select SYSTEM_TYPE_LAPTOP select USE_NATIVE_RAMINIT - select EC_HP_KBC1126 - select SUPERIO_SMSC_LPC47N217 - select HAVE_OPTION_TABLE - select HAVE_CMOS_DEFAULT - select MAINBOARD_USES_IFD_GBE_REGION
config MAINBOARD_DIR string diff --git a/src/mainboard/hp/folio_9470m/Kconfig b/src/mainboard/hp/folio_9470m/Kconfig index 634cb92..b40ca25 100644 --- a/src/mainboard/hp/folio_9470m/Kconfig +++ b/src/mainboard/hp/folio_9470m/Kconfig @@ -4,21 +4,21 @@ def_bool y select BOARD_ROMSIZE_KB_16384 select EC_HP_KBC1126 + select GFX_GMA_INTERNAL_IS_LVDS select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select HAVE_CMOS_DEFAULT + select HAVE_OPTION_TABLE + select INTEL_GMA_HAVE_VBT select INTEL_INT15 + select MAINBOARD_HAS_LIBGFXINIT + select MAINBOARD_HAS_LPC_TPM + select MAINBOARD_USES_IFD_GBE_REGION select NORTHBRIDGE_INTEL_SANDYBRIDGE select SERIRQ_CONTINUOUS_MODE select SOUTHBRIDGE_INTEL_C216 select SYSTEM_TYPE_LAPTOP select USE_NATIVE_RAMINIT - select MAINBOARD_HAS_LPC_TPM - select HAVE_OPTION_TABLE - select HAVE_CMOS_DEFAULT - select MAINBOARD_HAS_LIBGFXINIT - select GFX_GMA_INTERNAL_IS_LVDS - select MAINBOARD_USES_IFD_GBE_REGION - select INTEL_GMA_HAVE_VBT
config MAINBOARD_DIR string diff --git a/src/mainboard/hp/revolve_810_g1/Kconfig b/src/mainboard/hp/revolve_810_g1/Kconfig index 3bcfc63..da27242 100644 --- a/src/mainboard/hp/revolve_810_g1/Kconfig +++ b/src/mainboard/hp/revolve_810_g1/Kconfig @@ -4,23 +4,23 @@ def_bool y select BOARD_ROMSIZE_KB_16384 select EC_HP_KBC1126 + select GENERIC_SPD_BIN + select GFX_GMA_INTERNAL_IS_LVDS select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select HAVE_CMOS_DEFAULT + select HAVE_OPTION_TABLE select INTEL_INT15 + select INTEL_GMA_HAVE_VBT + select MAINBOARD_USES_IFD_GBE_REGION + select MAINBOARD_HAS_LIBGFXINIT + select MAINBOARD_HAS_LPC_TPM + select MAINBOARD_HAS_TPM1 select NORTHBRIDGE_INTEL_SANDYBRIDGE select SERIRQ_CONTINUOUS_MODE select SOUTHBRIDGE_INTEL_C216 select SYSTEM_TYPE_LAPTOP select USE_NATIVE_RAMINIT - select MAINBOARD_HAS_LPC_TPM - select MAINBOARD_HAS_TPM1 - select GENERIC_SPD_BIN - select HAVE_OPTION_TABLE - select HAVE_CMOS_DEFAULT - select MAINBOARD_HAS_LIBGFXINIT - select GFX_GMA_INTERNAL_IS_LVDS - select MAINBOARD_USES_IFD_GBE_REGION - select INTEL_GMA_HAVE_VBT
config MAINBOARD_DIR string
-
Angel Pons (Code Review) -
Nico Huber (Code Review)