Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/38284 )
Change subject: Improve error message if database is missing ......................................................................
Improve error message if database is missing
If the chip configs database is missing, the tool should provide a hint on how to fix the issue.
Change-Id: Iefbb5ecec9511e76e5ef2b547f5788144370fd28 Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M em100.c 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/em100 refs/changes/84/38284/1
diff --git a/em100.c b/em100.c index 46f2c64..f925342 100644 --- a/em100.c +++ b/em100.c @@ -671,7 +671,8 @@ configs = tar_load_compressed(configs_name); free(configs_name); if (!configs) { - printf("Can't find chip configs in $EM100_HOME/configs.tar.xz.\n"); + printf("Can't find chip configs in $EM100_HOME/configs.tar.xz.\n" + "Please run em100 --update-files.\n"); return NULL; }
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/em100/+/38284 )
Change subject: Improve error message if database is missing ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/em100/+/38284/1/em100.c File em100.c:
https://review.coreboot.org/c/em100/+/38284/1/em100.c@675 PS1, Line 675: em100 --update-files I'd put the command between `backticks` or change it slightly:
Please run: em100 --update-files
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/em100/+/38284
to look at the new patch set (#2).
Change subject: Improve error message if database is missing ......................................................................
Improve error message if database is missing
If the chip configs database is missing, the tool should provide a hint on how to fix the issue.
Change-Id: Iefbb5ecec9511e76e5ef2b547f5788144370fd28 Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M em100.c 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/em100 refs/changes/84/38284/2
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/38284 )
Change subject: Improve error message if database is missing ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/em100/+/38284/1/em100.c File em100.c:
https://review.coreboot.org/c/em100/+/38284/1/em100.c@675 PS1, Line 675: em100 --update-files
I'd put the command between `backticks` or change it slightly: […]
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/em100/+/38284 )
Change subject: Improve error message if database is missing ......................................................................
Patch Set 2: Code-Review+2
Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/em100/+/38284 )
Change subject: Improve error message if database is missing ......................................................................
Improve error message if database is missing
If the chip configs database is missing, the tool should provide a hint on how to fix the issue.
Change-Id: Iefbb5ecec9511e76e5ef2b547f5788144370fd28 Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Reviewed-on: https://review.coreboot.org/c/em100/+/38284 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M em100.c 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/em100.c b/em100.c index 46f2c64..2d51bc9 100644 --- a/em100.c +++ b/em100.c @@ -671,7 +671,8 @@ configs = tar_load_compressed(configs_name); free(configs_name); if (!configs) { - printf("Can't find chip configs in $EM100_HOME/configs.tar.xz.\n"); + printf("Can't find chip configs in $EM100_HOME/configs.tar.xz.\n" + "Please run: em100 --update-files.\n"); return NULL; }