Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38089 )
Change subject: HP sandy/ivy laptops: Sort Kconfig `select` lines
......................................................................
Patch Set 1:
Patch Set 1: Code-Review+2
I would prefer grouping by topic over fully alphabetically, though.
The sorting was to ease merging of the various variants together. Then, when adding variants, I just had to go through the original Kconfig selects and delete the ones in the variant-enabled Kconfig. Then, the result goes into Kconfig.name as-is.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38089
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica7462d28d2aad184b6545db46547a01bc2a8ccb
Gerrit-Change-Number: 38089
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 10 Jan 2020 19:37:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment