Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56033 )
Change subject: mb/siemens/mc_ehl: Provide a proper scheme for variants ......................................................................
mb/siemens/mc_ehl: Provide a proper scheme for variants
There will be more variants of this mainboard so prepare the scheme for Kconfig to handle the variants properly.
Change-Id: If1cf418836d77a45955ee55d30ba670db8ff2533 Signed-off-by: Werner Zeh werner.zeh@siemens.com --- M src/mainboard/siemens/mc_ehl/Kconfig M src/mainboard/siemens/mc_ehl/Kconfig.name 2 files changed, 14 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/56033/1
diff --git a/src/mainboard/siemens/mc_ehl/Kconfig b/src/mainboard/siemens/mc_ehl/Kconfig index c2eb56e..b5a5a90 100644 --- a/src/mainboard/siemens/mc_ehl/Kconfig +++ b/src/mainboard/siemens/mc_ehl/Kconfig @@ -1,7 +1,5 @@ -if BOARD_SIEMENS_MC_EHL - -config BOARD_SPECIFIC_OPTIONS - def_bool y +config BOARD_SIEMENS_BASEBOARD_MC_EHL + def_bool n select BOARD_ROMSIZE_KB_32768 select DRIVERS_I2C_HID select DRIVERS_INTEL_DPTF @@ -14,21 +12,21 @@ select HAVE_ACPI_TABLES select SOC_INTEL_ELKHARTLAKE
+source "src/mainboard/siemens/mc_ehl/variants/*/Kconfig" + +if BOARD_SIEMENS_BASEBOARD_MC_EHL + config MAINBOARD_DIR string default "siemens/mc_ehl"
config VARIANT_DIR string - default "mc_ehl1" if BOARD_SIEMENS_MC_EHL + default "mc_ehl1" if BOARD_SIEMENS_MC_EHL1
config MAINBOARD_PART_NUMBER string - default "MC EHL" - -config MAINBOARD_FAMILY - string - default "Siemens EHL" + default "MC EHL1" if BOARD_SIEMENS_MC_EHL1
config DEVICETREE string @@ -47,4 +45,4 @@ default 2 if INTEL_LPSS_UART_FOR_CONSOLE default 0
-endif +endif # BOARD_SIEMENS_BASEBOARD_MC_EHL diff --git a/src/mainboard/siemens/mc_ehl/Kconfig.name b/src/mainboard/siemens/mc_ehl/Kconfig.name index 0560d39..e38e1e4 100644 --- a/src/mainboard/siemens/mc_ehl/Kconfig.name +++ b/src/mainboard/siemens/mc_ehl/Kconfig.name @@ -1,2 +1,5 @@ -config BOARD_SIEMENS_MC_EHL - bool "MC EHL" +comment "MC EHLx" + +config BOARD_SIEMENS_MC_EHL1 + bool "-> MC EHL1" + select BOARD_SIEMENS_BASEBOARD_MC_EHL