[XL] Change in coreboot[main]: soc/mediatek/mt8196: Add RTC driver

[Yu-Ping Wu (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Shunxi Zhang, Yidi Lin.

Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85978?usp=email )

Change subject: soc/mediatek/mt8196: Add RTC driver
......................................................................

Patch Set 3:

(17 comments)

File src/soc/mediatek/mt8196/include/soc/mt6685_rtc.h:

https://review.coreboot.org/c/coreboot/+/85978/comment/2dbbde36_6b558ea3?usp... :
PS2, Line 84: /*
            :  * Complete the RTC initialization process,
            :  * setting of related registers
            :  */
> `/* Complete the RTC initialization process and register settings. […]

Done

File src/soc/mediatek/mt8196/include/soc/rtc.h:

https://review.coreboot.org/c/coreboot/+/85978/comment/ef52f750_a4bae687?usp... :
PS2, Line 58: WATCH_INIT
> If this means "stopwatch_init", please use a more descriptive name. […]

Done

https://review.coreboot.org/c/coreboot/+/85978/comment/bcd876da_3f60e4e4?usp... :
PS2, Line 59: WAIT_EOSC_CHECK_CLK_RDY_TIME_US
> `EOSC_CHECK_CLK_TIMEOUT_US`

Done

https://review.coreboot.org/c/coreboot/+/85978/comment/caa7f056_d411e1d1?usp... :
PS2, Line 60: RETRY_MAX_TIME
> `RECOVERY_RETRY_COUNT`

Done

File src/soc/mediatek/mt8196/mt6685_rtc.c:

https://review.coreboot.org/c/coreboot/+/85978/comment/2e40a3d3_b702faba?usp... :
PS1, Line 68: 			     RG_BANK_FQMTR_RST_SHIFT);
> keep comment unresolved

Done

File src/soc/mediatek/mt8196/mt6685_rtc.c:

https://review.coreboot.org/c/coreboot/+/85978/comment/38205d9d_363fa134?usp... :
PS2, Line 101: ERROR: get frequency
> `FQMTR read`

Done

https://review.coreboot.org/c/coreboot/+/85978/comment/c5117fee_9aef9309?usp... :
PS2, Line 105: 26M/32K = 794
> `26MHz / 23K = (26 * 10^6) / (23 * 1024) ~= 794`

Done

https://review.coreboot.org/c/coreboot/+/85978/comment/12c11481_9abac1a2?usp... :
PS2, Line 139:
> You removed the wrong blank line. […]

Done

https://review.coreboot.org/c/coreboot/+/85978/comment/316f9b0d_d4e716b4?usp... :
PS2, Line 325: rtc_powerkey_init();
             : 
             : 	if (!rtc_write_trigger())
             : 		return false;
> `rtc_powerkey_init` already contains `rtc_write_trigger`. Change this to […]

Done

https://review.coreboot.org/c/coreboot/+/85978/comment/71d3a3dc_b3340d73?usp... :
PS2, Line 340: rtc_powerkey_init();
             : 	if (!rtc_write_trigger())
             : 		return false;
>

Done

https://review.coreboot.org/c/coreboot/+/85978/comment/2289d520_fe91b100?usp... :
PS2, Line 375: wrritten
> written

Done

https://review.coreboot.org/c/coreboot/+/85978/comment/b3270035_20413460?usp... :
PS2, Line 391: wrritten
> written

Done

https://review.coreboot.org/c/coreboot/+/85978/comment/6bffbfce_c4a1fbec?usp... :
PS2, Line 414: need
> `needs to`

Done

https://review.coreboot.org/c/coreboot/+/85978/comment/7734fbff_c260fc75?usp... :
PS2, Line 415: rtc_powerkey_init();
             : 
             : 	if (!rtc_write_trigger()) {
> `if (!rtc_powerkey_init()) {`

Done

https://review.coreboot.org/c/coreboot/+/85978/comment/d7963f44_7b324dbd?usp... :
PS2, Line 419: rtc_write_trigger
> `rtc_powerkey_init failed`

Done

https://review.coreboot.org/c/coreboot/+/85978/comment/d71f07df_c4ecd283?usp... :
PS2, Line 425:
> failed

Done

https://review.coreboot.org/c/coreboot/+/85978/comment/aafd67ea_70c893d0?usp... :
PS2, Line 504: Check clock source are match with 32K exist
> `Check if clock sources match existing 32K` […]

Done