Attention is currently required from: Subrata Banik, Paul Menzel, Tim Wawrzynczak, Angel Pons, EricR Lai, Karthik Ramasubramanian.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61110 )
Change subject: mb/google/brya: Merge gpio table before configuration
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/61110/comment/9d5208f4_76dbc12a
PS7, Line 16: struct pad_config *variant_gpio_override_table(size_t *num);
Why is it necessary to remove const from variant_gpio_override_table() prototype?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61110
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I595e7587765df663d1e2fa67efcef9b44c526dd0
Gerrit-Change-Number: 61110
Gerrit-PatchSet: 7
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 04 Feb 2022 22:56:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment