Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34158 )
Change subject: arch/x86: Drop some HAVE_SMI_HANDLER guards ......................................................................
arch/x86: Drop some HAVE_SMI_HANDLER guards
Change-Id: I4f7196febd091325eddceb77870acd40dbe332f9 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/soc/amd/picasso/Makefile.inc M src/soc/amd/stoneyridge/Makefile.inc M src/soc/intel/denverton_ns/Makefile.inc M src/soc/intel/fsp_broadwell_de/Makefile.inc M src/southbridge/amd/agesa/hudson/Makefile.inc M src/southbridge/amd/pi/hudson/Makefile.inc M src/southbridge/intel/lynxpoint/Makefile.inc 7 files changed, 12 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/34158/1
diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc index 93a8bbb..7e84e41 100644 --- a/src/soc/amd/picasso/Makefile.inc +++ b/src/soc/amd/picasso/Makefile.inc @@ -56,7 +56,7 @@ romstage-y += tsc_freq.c romstage-y += southbridge.c romstage-$(CONFIG_SPI_FLASH) += spi.c -romstage-$(CONFIG_HAVE_SMI_HANDLER) += smi_util.c +romstage-y += smi_util.c
verstage-y += gpio.c verstage-y += i2c.c @@ -89,7 +89,7 @@ ramstage-y += smbus.c ramstage-y += ramtop.c ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smi.c -ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smi_util.c +ramstage-y += smi_util.c ramstage-$(CONFIG_PICASSO_UART) += uart.c ramstage-y += usb.c ramstage-y += tsc_freq.c diff --git a/src/soc/amd/stoneyridge/Makefile.inc b/src/soc/amd/stoneyridge/Makefile.inc index babd878..230640a 100644 --- a/src/soc/amd/stoneyridge/Makefile.inc +++ b/src/soc/amd/stoneyridge/Makefile.inc @@ -50,7 +50,7 @@ bootblock-y += southbridge.c bootblock-y += nb_util.c bootblock-$(CONFIG_SPI_FLASH) += spi.c -bootblock-$(CONFIG_HAVE_SMI_HANDLER) += smi_util.c +bootblock-y += smi_util.c
romstage-y += BiosCallOuts.c romstage-y += i2c.c @@ -68,7 +68,7 @@ romstage-y += southbridge.c romstage-y += nb_util.c romstage-$(CONFIG_SPI_FLASH) += spi.c -romstage-$(CONFIG_HAVE_SMI_HANDLER) += smi_util.c +romstage-y += smi_util.c
verstage-y += gpio.c verstage-y += i2c.c @@ -105,7 +105,7 @@ ramstage-y += smbus.c ramstage-y += ramtop.c ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smi.c -ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smi_util.c +ramstage-y += smi_util.c ramstage-$(CONFIG_STONEYRIDGE_UART) += uart.c ramstage-y += usb.c ramstage-y += tsc_freq.c diff --git a/src/soc/intel/denverton_ns/Makefile.inc b/src/soc/intel/denverton_ns/Makefile.inc index cfd8149..1f12db7 100644 --- a/src/soc/intel/denverton_ns/Makefile.inc +++ b/src/soc/intel/denverton_ns/Makefile.inc @@ -67,7 +67,7 @@ ramstage-$(CONFIG_DRIVERS_UART_8250MEM) += uart_debug.c ramstage-$(CONFIG_HAVE_ACPI_TABLES) += acpi.c ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smm.c -ramstage-$(CONFIG_HAVE_SMI_HANDLER) += pmutil.c +ramstage-y += pmutil.c ramstage-$(CONFIG_DISPLAY_UPD_DATA) += upd_display.c ramstage-$(CONFIG_DISPLAY_HOBS) += hob_display.c
diff --git a/src/soc/intel/fsp_broadwell_de/Makefile.inc b/src/soc/intel/fsp_broadwell_de/Makefile.inc index 1aba88b..d957778 100644 --- a/src/soc/intel/fsp_broadwell_de/Makefile.inc +++ b/src/soc/intel/fsp_broadwell_de/Makefile.inc @@ -29,7 +29,7 @@ ramstage-y += gpio.c ramstage-y += iou_complto.c ramstage-y += smmrelocate.c -ramstage-$(CONFIG_HAVE_SMI_HANDLER) += pmutil.c +ramstage-y += pmutil.c ramstage-y += vtd.c smm-y += pmutil.c smm-y += smihandler.c diff --git a/src/southbridge/amd/agesa/hudson/Makefile.inc b/src/southbridge/amd/agesa/hudson/Makefile.inc index cd0a1d5..5603a20 100644 --- a/src/southbridge/amd/agesa/hudson/Makefile.inc +++ b/src/southbridge/amd/agesa/hudson/Makefile.inc @@ -32,7 +32,8 @@ ramstage-y += imc.c
smm-y += smihandler.c smi_util.c -ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smi.c smi_util.c +ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smi.c +ramstage-y += smi_util.c
# ROMSIG At ROMBASE + 0x20000: # +-----------+---------------+----------------+------------+ diff --git a/src/southbridge/amd/pi/hudson/Makefile.inc b/src/southbridge/amd/pi/hudson/Makefile.inc index c8949b0..ac198aa 100644 --- a/src/southbridge/amd/pi/hudson/Makefile.inc +++ b/src/southbridge/amd/pi/hudson/Makefile.inc @@ -56,7 +56,7 @@ ramstage-y += sd.c ramstage-y += sm.c ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smi.c -ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smi_util.c +ramstage-y += smi_util.c ramstage-$(CONFIG_HUDSON_UART) += uart.c ramstage-y += usb.c
diff --git a/src/southbridge/intel/lynxpoint/Makefile.inc b/src/southbridge/intel/lynxpoint/Makefile.inc index e53ed8d..8be9234 100644 --- a/src/southbridge/intel/lynxpoint/Makefile.inc +++ b/src/southbridge/intel/lynxpoint/Makefile.inc @@ -38,10 +38,11 @@ ramstage-y += rcba.c ramstage-y += me_status.c ramstage-y += acpi.c +ramstage-y += pmutil.c
ramstage-$(CONFIG_ELOG) += elog.c
-ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smi.c pmutil.c +ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smi.c smm-y += smihandler.c me_9.x.c pch.c smm-y += pmutil.c usb_ehci.c usb_xhci.c
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34158 )
Change subject: arch/x86: Drop some HAVE_SMI_HANDLER guards ......................................................................
Patch Set 1: Code-Review-2
Hello Patrick Rudolph, Vanny E, Philipp Deppenwiese, build bot (Jenkins), David Guckian, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34158
to look at the new patch set (#2).
Change subject: [TESTONLY] arch/x86: Drop some HAVE_SMI_HANDLER guards ......................................................................
[TESTONLY] arch/x86: Drop some HAVE_SMI_HANDLER guards
Implementation of PARALLEL_MP appears to be very tightly coupled to dependencies that are currently guarded with HAVE_SMI_HANDLER.
Try to pass builds with HAVE_SMI_HANDLER=n.
Change-Id: I4f7196febd091325eddceb77870acd40dbe332f9 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/cpu/intel/haswell/Makefile.inc M src/cpu/intel/smm/gen1/Makefile.inc M src/soc/amd/picasso/Makefile.inc M src/soc/amd/stoneyridge/Makefile.inc M src/soc/intel/denverton_ns/Makefile.inc M src/soc/intel/fsp_baytrail/Makefile.inc M src/soc/intel/fsp_broadwell_de/Makefile.inc M src/southbridge/intel/lynxpoint/Makefile.inc 8 files changed, 16 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/34158/2
Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34158 )
Change subject: [TESTONLY] arch/x86: Drop some HAVE_SMI_HANDLER guards ......................................................................
Abandoned
Kyösti Mälkki has restored this change. ( https://review.coreboot.org/c/coreboot/+/34158 )
Change subject: [TESTONLY] arch/x86: Drop some HAVE_SMI_HANDLER guards ......................................................................
Restored
Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34158 )
Change subject: [TESTONLY] arch/x86: Drop some HAVE_SMI_HANDLER guards ......................................................................
Abandoned
-
Kyösti Mälkki (Code Review)