[S] Change in coreboot[main]: util/cbfstool: eliminate late sign of life event

[Subrata Banik (Code Review)]

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85621?usp=email )

Change subject: util/cbfstool: eliminate late sign of life event
......................................................................

util/cbfstool: eliminate late sign of life event

The purpose of the late sign-of-life (SOL) event was to add logs for
the CSE sync at the payload. However, recent changes have decoupled CSE
sync and SOL events, resulting in redundant event logging. This update
eliminates the superfluous late SOL event logs.

BUG=b:379585294
TEST=boot verified on google/rex0 and google/rex64

without change:
```
rex-rev3 ~ # elogtool list
rex64-rev3 ~ # /media/usb/elogtool list
0 | 2024-01-01 22:50:19-0800 | Log area cleared | 250
1 | 2024-01-01 22:50:59-0800 | System boot | 30
2 | 2024-01-01 22:50:59-0800 | Firmware Splash Screen | Enabled
3 | 2024-01-01 22:51:00-0800 | Power Fail
4 | 2024-01-01 22:51:00-0800 | SUS Power Fail
5 | 2024-01-01 22:51:00-0800 | ACPI Wake | S5
6 | 2024-01-01 22:51:00-0800 | Wake Source | Power Button | 0
7 | 2024-01-01 22:51:00-0800 | Late Sign of Life  | CSE Sync Late SOL Screen Shown
8 | 2024-01-01 22:51:00-0800 | Firmware CSE sync | CSE Sync at Payload
```
with change:
```
rex64-rev3 ~ # elogtool list
0 | 2024-12-17 02:42:23-0800 | Log area cleared | 141
1 | 2024-12-17 02:43:14-0800 | System boot | 81
2 | 2024-12-17 02:43:14-0800 | Firmware Splash Screen | Enabled
3 | 2024-12-17 02:43:16-0800 | Power Fail
4 | 2024-12-17 02:43:16-0800 | SUS Power Fail
5 | 2024-12-17 02:43:16-0800 | ACPI Wake | S5
6 | 2024-12-17 02:43:16-0800 | Wake Source | Power Button | 0
7 | 2024-12-17 02:43:16-0800 | Firmware CSE sync | CSE Sync at Payload
```

Change-Id: I53baecb3ca0cef5e0e18732e02832e8331e000d0
Signed-off-by: Dinesh Gehlot 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85621
Reviewed-by: Subrata Banik 
Tested-by: build bot (Jenkins) 
Reviewed-by: Kapil Porwal 
---
M src/commonlib/bsd/include/commonlib/bsd/elog.h
M util/cbfstool/eventlog.c
2 files changed, 0 insertions(+), 18 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Kapil Porwal: Looks good to me, approved
  Subrata Banik: Looks good to me, approved

diff --git a/src/commonlib/bsd/include/commonlib/bsd/elog.h b/src/commonlib/bsd/include/commonlib/bsd/elog.h
index 9032abc..e1c8f5d 100644
--- a/src/commonlib/bsd/include/commonlib/bsd/elog.h
+++ b/src/commonlib/bsd/include/commonlib/bsd/elog.h
@@ -382,12 +382,6 @@
 #define ELOG_TYPE_FW_SPLASH_SCREEN        0xbb

/*
- * Events related to CSE sync from payload
- */
-#define ELOG_TYPE_FW_LATE_SOL             0xbc
-#define  ELOG_FW_LATE_SOL_CSE_SYNC         0x0
-
-/*
  * Events related to CSE sync
  */
 #define ELOG_TYPE_FW_CSE_SYNC             0xbd
diff --git a/util/cbfstool/eventlog.c b/util/cbfstool/eventlog.c
index e3fccde..0227683 100644
--- a/util/cbfstool/eventlog.c
+++ b/util/cbfstool/eventlog.c
@@ -169,7 +169,6 @@
    	{ELOG_TYPE_PSR_DATA_BACKUP, "PSR data backup"},
    	{ELOG_TYPE_PSR_DATA_LOST, "PSR data lost"},
    	{ELOG_TYPE_FW_SPLASH_SCREEN, "Firmware Splash Screen"},
-		{ELOG_TYPE_FW_LATE_SOL, "Late Sign of Life "},
    	{ELOG_TYPE_FW_CSE_SYNC, "Firmware CSE sync"},
    	{ELOG_TYPE_EOL, "End of log"},
    };
@@ -485,11 +484,6 @@
    	{0, NULL},
    };

-	static const struct valstr late_sol_path_types[] = {
-		{ELOG_FW_LATE_SOL_CSE_SYNC, "CSE Sync Late SOL Screen Shown"},
-		{0, NULL},
-	};
-
    static const struct valstr cse_sync_path_types[] = {
    	{ELOG_FW_EARLY_CSE_SYNC, "Early CSE Sync"},
    	{ELOG_FW_LATE_CSE_SYNC, "Late CSE Sync"},
@@ -518,7 +512,6 @@
    	[ELOG_TYPE_FW_EARLY_SOL]	= sizeof(uint8_t),
    	[ELOG_TYPE_PSR_DATA_BACKUP]	= sizeof(uint8_t),
    	[ELOG_TYPE_FW_SPLASH_SCREEN]	= sizeof(uint8_t),
-		[ELOG_TYPE_FW_LATE_SOL]		= sizeof(uint8_t),
    	[ELOG_TYPE_FW_CSE_SYNC]		= sizeof(uint8_t),
    	[0xff]				= 0,
    };
@@ -686,11 +679,6 @@
    	eventlog_printf("%s", *fw_splash_screen_event ? "Enabled" : "Disabled");
    	break;
    }
-	case ELOG_TYPE_FW_LATE_SOL: {
-		const uint8_t *sol_event = event_get_data(event);
-		eventlog_printf("%s", val2str(*sol_event, late_sol_path_types));
-		break;
-	}
    case ELOG_TYPE_FW_CSE_SYNC: {
    	const uint8_t *cse_event = event_get_data(event);
    	eventlog_printf("%s", val2str(*cse_event, cse_sync_path_types));