Change in coreboot[master]: mb/facebook/monolith: Enable the xDCI controller

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Wim Vervoorn (Code Review)

16 Jan 2020 16 Jan '20

11:41 a.m.

Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38451 )

Change subject: mb/facebook/monolith: Enable the xDCI controller ......................................................................

mb/facebook/monolith: Enable the xDCI controller

Enable the VBOOT_ALWAYS_ALLOW_UDC option to actually enable the xDCI controller.

BUG=N/A TEST=build

Change-Id: Ib51f2c82e69db83cebceb71ba5f1305764e0feca Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/monolith/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/38451/1

diff --git a/src/mainboard/facebook/monolith/Kconfig b/src/mainboard/facebook/monolith/Kconfig index 3261661..ba42893 100644 --- a/src/mainboard/facebook/monolith/Kconfig +++ b/src/mainboard/facebook/monolith/Kconfig @@ -11,6 +11,7 @@ select MAINBOARD_HAS_TPM2 select MAINBOARD_USES_IFD_GBE_REGION select INTEL_GMA_HAVE_VBT + select VBOOT_ALWAYS_ALLOW_UDC

config CBFS_SIZE hex "CBFS_SIZE"

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Wim Vervoorn (Code Review)

16 Jan 16 Jan

1:10 p.m.

Hello Frans Hendriks, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38451

to look at the new patch set (#2).

Change subject: mb/facebook/monolith: Enable the xDCI controller ......................................................................

mb/facebook/monolith: Enable the xDCI controller

Enable the VBOOT_ALWAYS_ALLOW_UDC option to actually enable the xDCI controller.

BUG=N/A TEST=build

Change-Id: Ib51f2c82e69db83cebceb71ba5f1305764e0feca Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/monolith/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/38451/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib51f2c82e69db83cebceb71ba5f1305764e0feca Gerrit-Change-Number: 38451 Gerrit-PatchSet: 2 Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Nico Huber (Code Review)

1:18 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38451 )

Change subject: mb/facebook/monolith: Enable the xDCI controller ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38451/2/src/mainboard/facebook/mono... File src/mainboard/facebook/monolith/Kconfig:

https://review.coreboot.org/c/coreboot/+/38451/2/src/mainboard/facebook/mono... PS2, Line 14: select VBOOT_ALWAYS_ALLOW_UDC if VBOOT Options with a prompt should only be selected if there really is no choice. Please just provide a default

config VBOOT_ALWAYS_ALLOW_UDC def_bool y

-- To view, visit https://review.coreboot.org/c/coreboot/+/38451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib51f2c82e69db83cebceb71ba5f1305764e0feca Gerrit-Change-Number: 38451 Gerrit-PatchSet: 2 Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 16 Jan 2020 12:18:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Wim Vervoorn (Code Review)

1:27 p.m.

Hello Frans Hendriks, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38451

to look at the new patch set (#3).

Change subject: mb/facebook/monolith: Enable the xDCI controller ......................................................................

mb/facebook/monolith: Enable the xDCI controller

Enable the VBOOT_ALWAYS_ALLOW_UDC option to actually enable the xDCI controller.

BUG=N/A TEST=build

Change-Id: Ib51f2c82e69db83cebceb71ba5f1305764e0feca Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/monolith/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/38451/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/38451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib51f2c82e69db83cebceb71ba5f1305764e0feca Gerrit-Change-Number: 38451 Gerrit-PatchSet: 3 Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

1:28 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38451 )

Change subject: mb/facebook/monolith: Enable the xDCI controller ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38451/3/src/mainboard/facebook/mono... File src/mainboard/facebook/monolith/Kconfig:

https://review.coreboot.org/c/coreboot/+/38451/3/src/mainboard/facebook/mono... PS3, Line 89: trailing whitespace

-- To view, visit https://review.coreboot.org/c/coreboot/+/38451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib51f2c82e69db83cebceb71ba5f1305764e0feca Gerrit-Change-Number: 38451 Gerrit-PatchSet: 3 Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 16 Jan 2020 12:28:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Wim Vervoorn (Code Review)

1:28 p.m.

Hello Frans Hendriks, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38451

to look at the new patch set (#4).

Change subject: mb/facebook/monolith: Enable the xDCI controller ......................................................................

mb/facebook/monolith: Enable the xDCI controller

Enable the VBOOT_ALWAYS_ALLOW_UDC option to actually enable the xDCI controller.

BUG=N/A TEST=build

Change-Id: Ib51f2c82e69db83cebceb71ba5f1305764e0feca Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/monolith/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/38451/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/38451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib51f2c82e69db83cebceb71ba5f1305764e0feca Gerrit-Change-Number: 38451 Gerrit-PatchSet: 4 Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Wim Vervoorn (Code Review)

1:29 p.m.

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38451 )

Change subject: mb/facebook/monolith: Enable the xDCI controller ......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38451/2/src/mainboard/facebook/mono... File src/mainboard/facebook/monolith/Kconfig:

https://review.coreboot.org/c/coreboot/+/38451/2/src/mainboard/facebook/mono... PS2, Line 14: select VBOOT_ALWAYS_ALLOW_UDC if VBOOT

...

Options with a prompt should only be selected if there really is no choice. […]

Done

https://review.coreboot.org/c/coreboot/+/38451/3/src/mainboard/facebook/mono... File src/mainboard/facebook/monolith/Kconfig:

https://review.coreboot.org/c/coreboot/+/38451/3/src/mainboard/facebook/mono... PS3, Line 89:

...

trailing whitespace

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib51f2c82e69db83cebceb71ba5f1305764e0feca Gerrit-Change-Number: 38451 Gerrit-PatchSet: 4 Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 16 Jan 2020 12:29:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: build bot (Jenkins) no-reply@coreboot.org Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Nico Huber (Code Review)

1:34 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38451 )

Change subject: mb/facebook/monolith: Enable the xDCI controller ......................................................................

Patch Set 4: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/38451/2/src/mainboard/facebook/mono... File src/mainboard/facebook/monolith/Kconfig:

https://review.coreboot.org/c/coreboot/+/38451/2/src/mainboard/facebook/mono... PS2, Line 14: select VBOOT_ALWAYS_ALLOW_UDC if VBOOT

...

Done

Thanks, that was fast :)

-- To view, visit https://review.coreboot.org/c/coreboot/+/38451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib51f2c82e69db83cebceb71ba5f1305764e0feca Gerrit-Change-Number: 38451 Gerrit-PatchSet: 4 Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 16 Jan 2020 12:34:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Wim Vervoorn wvervoorn@eltan.com Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Wim Vervoorn (Code Review)

17 Jan 17 Jan

3:47 p.m.

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38451 )

Change subject: mb/facebook/monolith: Enable the xDCI controller ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38451/2/src/mainboard/facebook/mono... File src/mainboard/facebook/monolith/Kconfig:

https://review.coreboot.org/c/coreboot/+/38451/2/src/mainboard/facebook/mono... PS2, Line 14: select VBOOT_ALWAYS_ALLOW_UDC if VBOOT

...

Thanks, that was fast :)

It's not a lot of work.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib51f2c82e69db83cebceb71ba5f1305764e0feca Gerrit-Change-Number: 38451 Gerrit-PatchSet: 4 Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 17 Jan 2020 14:47:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wim Vervoorn wvervoorn@eltan.com Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Frans Hendriks (Code Review)

3:58 p.m.

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38451 )

Change subject: mb/facebook/monolith: Enable the xDCI controller ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib51f2c82e69db83cebceb71ba5f1305764e0feca Gerrit-Change-Number: 38451 Gerrit-PatchSet: 4 Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 17 Jan 2020 14:58:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

18 Jan 18 Jan

12:17 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38451 )

Change subject: mb/facebook/monolith: Enable the xDCI controller ......................................................................

mb/facebook/monolith: Enable the xDCI controller

Enable the VBOOT_ALWAYS_ALLOW_UDC option to actually enable the xDCI controller.

BUG=N/A TEST=build

Change-Id: Ib51f2c82e69db83cebceb71ba5f1305764e0feca Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38451 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/monolith/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Frans Hendriks: Looks good to me, approved

diff --git a/src/mainboard/facebook/monolith/Kconfig b/src/mainboard/facebook/monolith/Kconfig index 3261661..877b537 100644 --- a/src/mainboard/facebook/monolith/Kconfig +++ b/src/mainboard/facebook/monolith/Kconfig @@ -87,4 +87,8 @@ default y depends on VBOOT

+config VBOOT_ALWAYS_ALLOW_UDC + def_bool y + depends on VBOOT && !CHROMEOS + endif

-- To view, visit https://review.coreboot.org/c/coreboot/+/38451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib51f2c82e69db83cebceb71ba5f1305764e0feca Gerrit-Change-Number: 38451 Gerrit-PatchSet: 5 Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1762

days inactive

1764

days old

coreboot-gerrit@coreboot.org

10 comments

5 participants

tags (0)

participants (5)

build bot (Jenkins) (Code Review)
Frans Hendriks (Code Review)
Nico Huber (Code Review)
Patrick Georgi (Code Review)
Wim Vervoorn (Code Review)