Attention is currently required from: Nico Huber, Paul Menzel.
Hello Felix Singer, Nico Huber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83504?usp=email
to look at the new patch set (#3).
Change subject: southbridge/intel: Use azalia_audio_init() instead of duplicating code ......................................................................
southbridge/intel: Use azalia_audio_init() instead of duplicating code
There are some differences between the southbridge's codec_detect() removed in this patch and the one in device/azalia_device.c.
The southbridge's codect_detect() was written a long time ago and mentions that it was "not working yet" in the commit message. Therefore, I believe that the differences was due to it being a rough implementation and did not follow the specification exactly in some places (e.g. only using 4 bits for codec_mask instead of 15 bits).
Change-Id: Ie174ba29c115e3a3419362602d3e3175c9a03708 Signed-off-by: Nicholas Sudsgaard devel+coreboot@nsudsgaard.com --- M src/southbridge/intel/i82801gx/azalia.c M src/southbridge/intel/i82801ix/azalia.c M src/southbridge/intel/i82801jx/azalia.c 3 files changed, 3 insertions(+), 128 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/83504/3