Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52910 )
Change subject: soc/amd/common: Add Kconfig/Makefile support for common/fsp/*
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/fsp/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/52910/comment/647c51e4_590306ba
PS2, Line 8: CPPFLAGS_common += -I$(src)/soc/amd/common/block/fsp/include/
i don't see that directory being used in the following patches, so this is probably unneeded, since it doesn't exist
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52910
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3497791e1963867c8fe06a42c111e5d0503ade1
Gerrit-Change-Number: 52910
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Wed, 05 May 2021 21:16:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment