Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38556 )
Change subject: libpayload/xhci: Fix MPS handling in set_address
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38556/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38556/1//COMMIT_MSG@10
PS1, Line 10: compares
compare
Done
https://review.coreboot.org/c/coreboot/+/38556/1//COMMIT_MSG@12
PS1, Line 12: if we need to change settings here.
Please don't, it looks very good.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38556
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32455483fceec56f14af6118b77615c14b3f9f39
Gerrit-Change-Number: 38556
Gerrit-PatchSet: 3
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 05 Feb 2020 03:12:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment