Change in coreboot[master]: sb/intel/i82801gx/azalia.c: Fix read on 16bits register - coreboot-gerrit

11 Feb 2022


      Attention is currently required from: Arthur Heymans, Patrick Rudolph, Elyes Haouas.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61845 )
Change subject: sb/intel/i82801gx/azalia.c: Fix read on 16bits register
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61845/comment/e51a1f94_44bc46f6 
PS3, Line 10: bits
bit
File src/southbridge/intel/i82801gx/azalia.c:
https://review.coreboot.org/c/coreboot/+/61845/comment/be49d86c_9fccd499 
PS3, Line 17: 	const u16 codec_mask = (1 << CONFIG_AZALIA_MAX_CODECS) - 1;
Why this form and not 0xf?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/61845
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I530aa21d5a26ade0bc071351ac609c84bd8eb2cb
Gerrit-Change-Number: 61845
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 11 Feb 2022 12:41:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment