Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69108 )
Change subject: cpu/x86/mp_init.c: Set a bogus initial lapic_id ......................................................................
cpu/x86/mp_init.c: Set a bogus initial lapic_id
This makes it easier to catch errors later if the ap_init code fails to properly set things up.
Change-Id: I938faf042bfa4fe1fc39e78ab740c9b210bc105c Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/69108 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jonathan Zhang jonzhang@fb.com --- M src/cpu/x86/mp_init.c 1 file changed, 22 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, but someone else must approve Jonathan Zhang: Looks good to me, approved
diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index e3b294f..8cd785e 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -375,9 +375,11 @@ /* Build the CPU device path */ cpu_path.type = DEVICE_PATH_APIC;
- /* Assuming linear APIC space allocation. AP will set its own - APIC id in the ap_init() path above. */ - cpu_path.apic.apic_id = info->cpu->path.apic.apic_id + i; + /* + * Set a bogus apic_id. + * AP will set its own APIC id in the ap_init() path above. + */ + cpu_path.apic.apic_id = UINT32_MAX;
/* Allocate the new CPU device structure */ new = alloc_find_dev(cpu_bus, &cpu_path);