Julius Werner has posted comments on this change. ( https://review.coreboot.org/19770 )
Change subject: soc/mediatek/mt8173: Move spi driver to use spi_bus_map ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/19770/1/src/soc/mediatek/mt8173/spi.c File src/soc/mediatek/mt8173/spi.c:
Line 304: default: Can take out the flash and the "wrong number" case now because generic code already makes sure this is only called for the right bus.
PS1, Line 311: spi_ctrlr_setup Should be NULL?
PS1, Line 331: ec Shouldn't have "ec" in the name in this file. Just spi_ctrlr.
Line 333: .bus_end = CONFIG_EC_GOOGLE_CHROMEEC_SPI_BUS, I guess it was never really a great idea to put this Kconfig in here because it's a board decision what is connected to this controller. This should just be a number and then the board should pick that number for the EC if it wants to. The two controllers don't really have numbers in MTK's documentation (they're just "the SPI controller" and "the NOR flash controller"), so I guess we can just arbitrarily decide to call this one 0.
-
Julius Werner (Code Review)