Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47606 )
Change subject: nb/intel/sandybridge: Rename loop variable ......................................................................
nb/intel/sandybridge: Rename loop variable
What `discover_edges_real` is shmooing is the DQS PI setting.
Change-Id: I67390ba315d618d153f91c0e8a81db04ec8f63e1 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47606/1
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index 257eae4..e740f55 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -2345,14 +2345,14 @@
static int discover_edges_real(ramctr_timing *ctrl, int channel, int slotrank, int *edges) { - int edge; + int dqs_pi; int stats[NUM_LANES][MAX_EDGE_TIMING + 1]; int lane;
- for (edge = 0; edge <= MAX_EDGE_TIMING; edge++) { + for (dqs_pi = 0; dqs_pi <= MAX_EDGE_TIMING; dqs_pi++) { FOR_ALL_LANES { - ctrl->timings[channel][slotrank].lanes[lane].rising = edge; - ctrl->timings[channel][slotrank].lanes[lane].falling = edge; + ctrl->timings[channel][slotrank].lanes[lane].rising = dqs_pi; + ctrl->timings[channel][slotrank].lanes[lane].falling = dqs_pi; } program_timings(ctrl, channel);
@@ -2372,7 +2372,7 @@ wait_for_iosav(channel);
FOR_ALL_LANES { - stats[lane][edge] = MCHBAR32(IOSAV_By_ERROR_COUNT_ch(channel, lane)); + stats[lane][dqs_pi] = MCHBAR32(IOSAV_By_ERROR_COUNT_ch(channel, lane)); } }
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47606 )
Change subject: nb/intel/sandybridge: Rename loop variable ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47606/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47606/1//COMMIT_MSG@9 PS1, Line 9: What `discover_edges_real` is shmooing is the DQS PI setting. My English is not so good. What does this mean?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47606 )
Change subject: nb/intel/sandybridge: Rename loop variable ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47606/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47606/1//COMMIT_MSG@9 PS1, Line 9: What `discover_edges_real` is shmooing is the DQS PI setting.
My English is not so good. […]
I guess the problem is the `shmooing` verb? It comes from: https://en.wikipedia.org/wiki/Shmoo_plot
The sentence means:
The `discover_edges_real` function actually tests a range of values for DQS PI and evaluates how the system responds.
Hello build bot (Jenkins), Arthur Heymans, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47606
to look at the new patch set (#2).
Change subject: nb/intel/sandybridge: Rename loop variable ......................................................................
nb/intel/sandybridge: Rename loop variable
The `discover_edges_real` function actually tests a range of values for DQS PI and evaluates how the system responds. Rename the loop variable.
Change-Id: I67390ba315d618d153f91c0e8a81db04ec8f63e1 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47606/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47606 )
Change subject: nb/intel/sandybridge: Rename loop variable ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47606/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47606/1//COMMIT_MSG@9 PS1, Line 9: What `discover_edges_real` is shmooing is the DQS PI setting.
I guess the problem is the `shmooing` verb? It comes from: https://en.wikipedia.org/wiki/Shmoo_plot […]
Done
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47606 )
Change subject: nb/intel/sandybridge: Rename loop variable ......................................................................
Patch Set 5: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47606 )
Change subject: nb/intel/sandybridge: Rename loop variable ......................................................................
nb/intel/sandybridge: Rename loop variable
The `discover_edges_real` function actually tests a range of values for DQS PI and evaluates how the system responds. Rename the loop variable.
Change-Id: I67390ba315d618d153f91c0e8a81db04ec8f63e1 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47606 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 5 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index b67eb56..893d6b2 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -2310,14 +2310,14 @@
static int find_read_mpr_margin(ramctr_timing *ctrl, int channel, int slotrank, int *edges) { - int edge; + int dqs_pi; int stats[NUM_LANES][MAX_EDGE_TIMING + 1]; int lane;
- for (edge = 0; edge <= MAX_EDGE_TIMING; edge++) { + for (dqs_pi = 0; dqs_pi <= MAX_EDGE_TIMING; dqs_pi++) { FOR_ALL_LANES { - ctrl->timings[channel][slotrank].lanes[lane].rising = edge; - ctrl->timings[channel][slotrank].lanes[lane].falling = edge; + ctrl->timings[channel][slotrank].lanes[lane].rising = dqs_pi; + ctrl->timings[channel][slotrank].lanes[lane].falling = dqs_pi; } program_timings(ctrl, channel);
@@ -2337,7 +2337,7 @@ wait_for_iosav(channel);
FOR_ALL_LANES { - stats[lane][edge] = MCHBAR32(IOSAV_By_ERROR_COUNT_ch(channel, lane)); + stats[lane][dqs_pi] = MCHBAR32(IOSAV_By_ERROR_COUNT_ch(channel, lane)); } }
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Felix Held (Code Review)