New patch to review for coreboot: 0a45a9f hp/pavilion_m6_1035dx: Fix GPIO map and add WLAN pin

[Alexandru Gagniuc]

Alexandru Gagniuc ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5491

-gerrit

commit 0a45a9f15c0357122997ee161b2e3a17cb57b0e8
Author: Alexandru Gagniuc 
Date:   Wed Apr 9 16:14:25 2014 -0500

hp/pavilion_m6_1035dx: Fix GPIO map and add WLAN pin

Change-Id: I07725b71508c8b08451022307ae934c1b227f7f9
    Signed-off-by: Alexandru Gagniuc 
---
 src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c b/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c
index 2b47baa..28f0929 100644
--- a/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c
+++ b/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c
@@ -342,11 +342,24 @@ CONST AP_MTRR_SETTINGS ROMDATA TrinityApMtrrSettingsList[] =
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
 //#define BLDCFG_IR_PIN_CONTROL	0x33

-GPIO_CONTROL   parmer_gpio[] = {
-	{183, Function1, GpioIn | GpioOutEnB | PullUpB},
+/*
+ * The GPIO control is not well documented in AGESA, and the BKDG does not
+ * mention what the pin functions are. Function1 seems to the the correct
+ * function for an output pin, although the driver can be disabled. The pin
+ * level is readable under both Function1 and Function0, meaning Function1 can
+ * be used as either input or output. We use Function1 for output pins.
+ * Note that the GipoOut bit does not mean that the GPIO is an output. That bit
+ * actually controls the output value, so GpioOut means "default to set".
+ * PullUpB is an inverted logic, so setting this bit means we're actually
+ * disabling the internal pull-up. The PullDown bit is NOT inverted logic.
+ * The output driver can be disabled with the GpioOutEnB, which is again,
+ * inverted logic. We do leave this bit cleared to enable the output.
+ */
+GPIO_CONTROL pavilion_m6_1035dx_gpio[] = {
+	{57, Function1, GpioOut | PullUpB},		/* WLAN enable */
    {-1}
 };
-#define BLDCFG_FCH_GPIO_CONTROL_LIST           (&parmer_gpio[0])
+#define BLDCFG_FCH_GPIO_CONTROL_LIST           (&pavilion_m6_1035dx_gpio[0])

// The following definitions specify the default values for various parameters in which there are
 // no clearly defined defaults to be used in the common file.  The values below are based on product