Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83572?usp=email )
Change subject: soc/mediatek/mt8196: Add a stub implementation of the MT8196 SoC ......................................................................
Patch Set 3:
(4 comments)
File src/soc/mediatek/mt8196/Kconfig:
https://review.coreboot.org/c/coreboot/+/83572/comment/5bd6ab54_6a6183bb?usp... : PS1, Line 1: config SOC_MEDIATEK_MT8196
add SPDX identifier.
Done
File src/soc/mediatek/mt8196/soc.c:
https://review.coreboot.org/c/coreboot/+/83572/comment/f803ca2d_c7eb4fa6?usp... : PS2, Line 5: #include <symbols.h>
I think we need CB:83570 before this patch to have symbols.h.
Acknowledged
File src/soc/mediatek/mt8196/timer.c:
https://review.coreboot.org/c/coreboot/+/83572/comment/0d55f397_47478ed2?usp... : PS1, Line 6: #include <soc/timer_common.h>
no need
Done
https://review.coreboot.org/c/coreboot/+/83572/comment/05afd5ea_e1fdd581?usp... : PS1, Line 10: timer_prepare();
remove
Done