Change in coreboot[master]: mb/google/zork: Turn off power to camera and pen in sleep path
Hello Aaron Durbin,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/42933
to review the following change.
Change subject: mb/google/zork: Turn off power to camera and pen in sleep path ......................................................................
mb/google/zork: Turn off power to camera and pen in sleep path
This change turns off power to camera and pen devices when entering sleep since they do not act as wake sources in S3. Power to trackpad and WiFi is left enabled since they are wake sources for S3.
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I21bcdd53370372c7d43c3b685abb2a9171e42d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+... Reviewed-by: Aaron Durbin adurbin@google.com Commit-Queue: Furquan Shaikh furquan@chromium.org Tested-by: Furquan Shaikh furquan@chromium.org --- M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_common.c 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/42933/1
diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_common.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_common.c index 614e837..e43b0b4c 100644 --- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_common.c +++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_common.c @@ -32,6 +32,10 @@ }
static const struct soc_amd_gpio gpio_sleep_table[] = { + /* PEN_POWER_EN */ + PAD_GPO(GPIO_5, LOW), + /* EN_PWR_CAMERA */ + PAD_GPO(GPIO_76, LOW), };
const __weak struct soc_amd_gpio *variant_sleep_gpio_table(size_t *size, int slp_typ)
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42933 )
Change subject: mb/google/zork: Turn off power to camera and pen in sleep path ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42933 )
Change subject: mb/google/zork: Turn off power to camera and pen in sleep path ......................................................................
mb/google/zork: Turn off power to camera and pen in sleep path
This change turns off power to camera and pen devices when entering sleep since they do not act as wake sources in S3. Power to trackpad and WiFi is left enabled since they are wake sources for S3.
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I21bcdd53370372c7d43c3b685abb2a9171e42d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+... Reviewed-by: Aaron Durbin adurbin@google.com Commit-Queue: Furquan Shaikh furquan@chromium.org Tested-by: Furquan Shaikh furquan@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/42933 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_common.c 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_common.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_common.c index 614e837..e43b0b4c 100644 --- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_common.c +++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_common.c @@ -32,6 +32,10 @@ }
static const struct soc_amd_gpio gpio_sleep_table[] = { + /* PEN_POWER_EN */ + PAD_GPO(GPIO_5, LOW), + /* EN_PWR_CAMERA */ + PAD_GPO(GPIO_76, LOW), };
const __weak struct soc_amd_gpio *variant_sleep_gpio_table(size_t *size, int slp_typ)
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)