Change in coreboot[master]: nb/intel/haswell: Use common {DMI,EP,MCH}BAR accessors - coreboot-gerrit

10 Feb 2021


      Attention is currently required from: Nico Huber, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49749 )
Change subject: nb/intel/haswell: Use common {DMI,EP,MCH}BAR accessors
......................................................................
Patch Set 6:
(1 comment)
File src/northbridge/intel/haswell/haswell.h:
https://review.coreboot.org/c/coreboot/+/49749/comment/80cfdd1b_fa7045da 
PS6, Line 64: #define EPBAR64(x) (*((volatile u64 *)(CONFIG_FIXED_EPBAR_MMIO_BASE + (x))))
...
Right, I'll update this patch to add the casts, and make another patch to add the casts to fixed_bar […]
Done here and in CB:50469
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49749
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ff4577ce662697cb3d8fb34003217fd6275dd42
Gerrit-Change-Number: 49749
Gerrit-PatchSet: 6
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Wed, 10 Feb 2021 09:18:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment