Change in coreboot[master]: Makefile.inc: Generate master header and pointer as C structs - coreboot-gerrit

5 Apr 2022


      Attention is currently required from: Arthur Heymans, Martin Roth, Julius Werner, Yu-Ping Wu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59132 )
Change subject: Makefile.inc: Generate master header and pointer as C structs
......................................................................
Patch Set 7:
(1 comment)
File src/arch/x86/bootblock.ld:
https://review.coreboot.org/c/coreboot/+/59132/comment/7407ce8d_c5d34f88 
PS7, Line 77: . = 0xfffffffc;
            : 	.header_pointer . : {
            : 		KEEP(*(.header_pointer));
            : 	}
This needs to be smarter. It looks like the reset vector is wrong when header_pointer is missing.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59132
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ba01be7da1f09a8cac287751497c18cda97d293
Gerrit-Change-Number: 59132
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Tue, 05 Apr 2022 18:53:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment