Attention is currently required from: Martin Roth, Felix Held. Nikolai Vyssotski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49865 )
Change subject: soc/amd/common/block/graphics/graphics: GOP: implement vbt_get() ......................................................................
Patch Set 11:
(2 comments)
File src/soc/amd/common/block/graphics/graphics.c:
https://review.coreboot.org/c/coreboot/+/49865/comment/b4ef92e3_258b20e8 PS9, Line 123:
i find the tab here a bit odd; would rather expect a space
Done
https://review.coreboot.org/c/coreboot/+/49865/comment/ec0ca05f_42fe4697 PS9, Line 129: return NULL;
would it make sense or be useful to pass the base address of the amd vbios instead of the intel vbt […]
I won't be using vbios_buffer in the next CL per Raul's suggestion so this is no longer relevant. If I were to keep it as is I would still prefer not to use this function to pass VBIOS pointer as VBT is non-standardized Intel structure with its own header and proprietary data.