David Hendricks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37256 )
Change subject: Documentation: Rework the bit about draft patches ......................................................................
Documentation: Rework the bit about draft patches
The draft workflow is now disabled, and private patches are the new way to submit a patch that is only visible to the author and certain reviewers.
Signed-off-by: David Hendricks david.hendricks@gmail.com Change-Id: I562c101ab2ee78d901be7e99165daba7473dc3c1 --- M Documentation/tutorial/part2.md 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/37256/1
diff --git a/Documentation/tutorial/part2.md b/Documentation/tutorial/part2.md index e532218..766592e 100644 --- a/Documentation/tutorial/part2.md +++ b/Documentation/tutorial/part2.md @@ -157,10 +157,10 @@ you to take back your commit and amend it.
When you are done with your commit, run `git push` to push your commit to -coreboot.org. **Note:** To submit as a draft, use -`git push origin HEAD:refs/drafts/master`. Submitting as a draft means that -your commit will be on coreboot.org, but is only visible to those you add -as reviewers. +coreboot.org. **Note:** To submit as a private patch, use +`git push origin HEAD:refs/for/master%private`. Submitting as a private patch +means that your commit will be on coreboot.org, but is only visible to those you +add as reviewers.
This has been a quick primer on how to submit a change to Gerrit for review using git. You may wish to review the [Gerrit code review workflow
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37256 )
Change subject: Documentation: Rework the bit about draft patches ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/37256/1/Documentation/tutorial/part... File Documentation/tutorial/part2.md:
https://review.coreboot.org/c/coreboot/+/37256/1/Documentation/tutorial/part... PS1, Line 162: coreboot.org unrelated: Should this be more specific: review.coreboot.org?
Hello Arthur Heymans, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37256
to look at the new patch set (#2).
Change subject: Documentation: Rework staging and commit information ......................................................................
Documentation: Rework staging and commit information
This patch does two things: - The CLI and Git Cola sections contained some duplicated information about pushing patches, which is now factored out into its own section. - The draft workflow is now disabled, so that part has been reworded to describe how to submit a private patch.
Signed-off-by: David Hendricks david.hendricks@gmail.com Change-Id: I562c101ab2ee78d901be7e99165daba7473dc3c1 --- M Documentation/tutorial/part2.md 1 file changed, 4 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/37256/2
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37256 )
Change subject: Documentation: Rework staging and commit information ......................................................................
Patch Set 2:
(1 comment)
I just realized that there is another part in the Git Cola section that talks about draft patches, so I re-factored section 4 so that parts a and b talk about staging commits and part c talks about pushing the commit to review.coreboot.org.
https://review.coreboot.org/c/coreboot/+/37256/1/Documentation/tutorial/part... File Documentation/tutorial/part2.md:
https://review.coreboot.org/c/coreboot/+/37256/1/Documentation/tutorial/part... PS1, Line 162: coreboot.org
unrelated: Should this be more specific: review.coreboot. […]
Yes.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37256 )
Change subject: Documentation: Rework staging and commit information ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37256 )
Change subject: Documentation: Rework staging and commit information ......................................................................
Documentation: Rework staging and commit information
This patch does two things: - The CLI and Git Cola sections contained some duplicated information about pushing patches, which is now factored out into its own section. - The draft workflow is now disabled, so that part has been reworded to describe how to submit a private patch.
Signed-off-by: David Hendricks david.hendricks@gmail.com Change-Id: I562c101ab2ee78d901be7e99165daba7473dc3c1 Reviewed-on: https://review.coreboot.org/c/coreboot/+/37256 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M Documentation/tutorial/part2.md 1 file changed, 4 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved
diff --git a/Documentation/tutorial/part2.md b/Documentation/tutorial/part2.md index e532218..3009e28 100644 --- a/Documentation/tutorial/part2.md +++ b/Documentation/tutorial/part2.md @@ -157,10 +157,10 @@ you to take back your commit and amend it.
When you are done with your commit, run `git push` to push your commit to -coreboot.org. **Note:** To submit as a draft, use -`git push origin HEAD:refs/drafts/master`. Submitting as a draft means that -your commit will be on coreboot.org, but is only visible to those you add -as reviewers. +coreboot.org. **Note:** To submit as a private patch, use +`git push origin HEAD:refs/for/master%private`. Submitting as a private patch +means that your commit will be on review.coreboot.org, but is only visible to +yourself and those you add as reviewers.
This has been a quick primer on how to submit a change to Gerrit for review using git. You may wish to review the [Gerrit code review workflow @@ -227,9 +227,6 @@
When ready, select 'Commit' again. Once all errors have been satisfied and the commit succeeds, move to the command line and run `git push`. -**Note:** To submit as a draft, use `git push origin HEAD:refs/drafts/master`. -Submitting as a draft means that your commit will be on coreboot.org, but is -only visible to those you add as reviewers.
## Part 5: Getting your commit reviewed
-
Arthur Heymans (Code Review) -
David Hendricks (Code Review)
-
Patrick Georgi (Code Review)
-
Stefan Reinauer (Code Review)