Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39895 )
Change subject: mb/ocp/tiogapass: Update UPD IIO bifurcation at run-time
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/39895/9/src/mainboard/ocp/tiogapass...
File src/mainboard/ocp/tiogapass/romstage.c:
https://review.coreboot.org/c/coreboot/+/39895/9/src/mainboard/ocp/tiogapass...
PS9, Line 60: oem_update_iio
Please move this to the end of the mainboard_config_iio() function.
This will allow us to avoid problems if someone updates tp_iio_pci_port_skt0 in the oem_update_iio() function in the future.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39895
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e63a233a2235cd45b14b20542e6efab3de17899
Gerrit-Change-Number: 39895
Gerrit-PatchSet: 9
Gerrit-Owner: Johnny Lin
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 22 Apr 2020 17:43:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment