Attention is currently required from: Anil Kumar K, Selma Bensaid, Paul Menzel, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61945 )
Change subject: soc/intel/common: Do bounds check on CPU core/thread number
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
Hi Tim. i added this assert at the root of problem , where the MSR is being read. […]
I understand what you're saying, but I think the real root is array access without bounds checking. Array accesses "have" to be bounds-checked in C, therefore the array accesses are where this should happen. I have no idea if all the hardware that this function is run on has CONFIG_MAX_CPUS already set up correctly to avoid hanging here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61945
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6cbbf3d45b71c3cf0c37dc42e3d0051cfa306487
Gerrit-Change-Number: 61945
Gerrit-PatchSet: 7
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 25 Feb 2022 16:43:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anil Kumar K
anil.kumar.k@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment