[XS] Change in coreboot[main]: drivers/intel/gma: Allow SPARK function with side effects

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80616?usp=email )

Change subject: drivers/intel/gma: Allow SPARK function with side effects
......................................................................

drivers/intel/gma: Allow SPARK function with side effects

Explicitly specifying the aspect `Side_Effects' is necessary for GCC
toolchains from 14.0 on. As older toolchains don't know the aspect,
we have to silence a warning about it, though.

Change-Id: I1eb879f57437587dc11d879fcc4042a70d384786
Signed-off-by: Nico Huber 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80616
Reviewed-by: Felix Singer 
Reviewed-by: Thomas Heijligen 
Tested-by: build bot (Jenkins) 
---
M gnat.adc
M src/drivers/intel/gma/gma.ads
2 files changed, 5 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Felix Singer: Looks good to me, approved
  Thomas Heijligen: Looks good to me, approved

diff --git a/gnat.adc b/gnat.adc
index 5a03406..5ebc91b 100644
--- a/gnat.adc
+++ b/gnat.adc
@@ -28,3 +28,7 @@
    Refined_Post         => Disable);
 pragma Overflow_Mode (General => Strict, Assertions => Eliminated);
 pragma SPARK_Mode (On);
+
+pragma Warnings
+  (GNAT, Off, """Side_Effects"" is not a valid aspect identifier",
+   Reason => """Side_Effects"" is new and needed for toolchain transition.");
diff --git a/src/drivers/intel/gma/gma.ads b/src/drivers/intel/gma/gma.ads
index d264960..5cb45da 100644
--- a/src/drivers/intel/gma/gma.ads
+++ b/src/drivers/intel/gma/gma.ads
@@ -11,6 +11,6 @@
       port     : in     Interfaces.C.int)
       return Interfaces.C.int
    with
-      Export, Convention => C, External_Name => "gma_read_edid";
+      Side_Effects, Export, Convention => C, External_Name => "gma_read_edid";

end GMA;