Change in coreboot[master]: driver/usb/acpi: Add power resources for devices on USB ports - coreboot-gerrit

6 Nov 2020


      Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46713 )
Change subject: driver/usb/acpi: Add power resources for devices on USB ports
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46713/4/src/drivers/usb/acpi/chip.h 
File src/drivers/usb/acpi/chip.h:
https://review.coreboot.org/c/coreboot/+/46713/4/src/drivers/usb/acpi/chip.h... 
PS4, Line 62: };
Just for consistency's sake, I would have left the stop GPIO in here.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/46713
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc1aebfb9e3e646a7f608f0cd391079fd30dd1c0
Gerrit-Change-Number: 46713
Gerrit-PatchSet: 4
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Peichao Wang pwang12@lenovo.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-Comment-Date: Fri, 06 Nov 2020 16:59:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment