Change in coreboot[master]: northbridge/amd/pi/00730F01/northbridge.c: remove unneded global vari...

[Michał Kopeć (Code Review)]

Michał Kopeć has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59870 )

Change subject: northbridge/amd/pi/00730F01/northbridge.c: remove unneded global variables
......................................................................

northbridge/amd/pi/00730F01/northbridge.c: remove unneded global variables

Remove global variables `sblink` and `node_nums`, add function
`get_node_nums()` which returns a static variable.

TEST=Boot Debian 11 on PC Engines apu3

Signed-off-by: Michał Kopeć 
Change-Id: I20a47f967093ef91355377c164656cabadc30fe6
---
M src/northbridge/amd/pi/00730F01/northbridge.c
1 file changed, 25 insertions(+), 24 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/59870/1

diff --git a/src/northbridge/amd/pi/00730F01/northbridge.c b/src/northbridge/amd/pi/00730F01/northbridge.c
index b56e9ca..6fc47db 100644
--- a/src/northbridge/amd/pi/00730F01/northbridge.c
+++ b/src/northbridge/amd/pi/00730F01/northbridge.c
@@ -29,8 +29,6 @@
 #define PCIE_CAP_AER		BIT(5)
 #define PCIE_CAP_ACS		BIT(6)

-static unsigned int node_nums;
-static unsigned int sblink;
 static struct device *__f0_dev[MAX_NODE_NUMS];
 static struct device *__f1_dev[MAX_NODE_NUMS];
 static struct device *__f2_dev[MAX_NODE_NUMS];
@@ -42,6 +40,25 @@
    return pcidev_on_root(DEV_CDB + nodeid, fn);
 }

+static struct device *get_mc_dev(void)
+{
+	return pcidev_on_root(DEV_CDB, 0);
+}
+
+static unsigned int get_node_nums(void)
+{
+	static unsigned int node_nums;
+	static int already_read;
+
+	if (already_read)
+		return node_nums;
+
+	node_nums = ((pci_read_config32(get_mc_dev(), 0x60)>>4) & 7) + 1; //NodeCnt[2:0]
+	already_read = 1;
+
+	return node_nums;
+}
+
 static void get_fx_devs(void)
 {
    int i;
@@ -164,6 +181,9 @@
 static void create_vga_resource(struct device *dev, unsigned int nodeid)
 {
    struct bus *link;
+	unsigned int sblink;
+
+	sblink = (pci_read_config32(get_mc_dev(), 0x64)>>8) & 7; // don't forget sublink1

/* find out which link the VGA card is connected,
     * we only deal with the 'first' vga card */
@@ -724,7 +744,7 @@
    int i;
    mem_hole.hole_startk = CONFIG_HW_MEM_HOLE_SIZEK;
    mem_hole.node_id = -1;
-	for (i = 0; i < node_nums; i++) {
+	for (i = 0; i < get_node_nums(); i++) {
    	resource_t basek, limitk;
    	u32 hole;
    	if (!get_dram_base_limit(i, &basek, &limitk))
@@ -742,7 +762,7 @@
     */
    if (mem_hole.node_id == -1) {
    	resource_t limitk_pri = 0;
-		for (i = 0; i < node_nums; i++) {
+		for (i = 0; i < get_node_nums(); i++) {
    		resource_t base_k, limit_k;
    		if (!get_dram_base_limit(i, &base_k, &limit_k))
    			continue; // no memory on this node
@@ -788,7 +808,7 @@
 #endif

idx = 0x10;
-	for (i = 0; i < node_nums; i++) {
+	for (i = 0; i < get_node_nums(); i++) {
    	resource_t basek, limitk, sizek; // 4 1T

if (!get_dram_base_limit(i, &basek, &limitk))
@@ -856,24 +876,6 @@
    .acpi_name        = domain_acpi_name,
 };

-static void sysconf_init(struct device *dev) // first node
-{
-	sblink = (pci_read_config32(dev, 0x64)>>8) & 7; // don't forget sublink1
-	node_nums = ((pci_read_config32(dev, 0x60)>>4) & 7) + 1; //NodeCnt[2:0]
-}
-
-static void cpu_bus_scan(struct device *dev)
-{
-	struct device *dev_mc;
-
-	dev_mc = pcidev_on_root(DEV_CDB, 0);
-	if (!dev_mc) {
-		printk(BIOS_ERR, "0:%02x.0 not found", DEV_CDB);
-		die("");
-	}
-	sysconf_init(dev_mc);
-}
-
 static void pre_mp_init(void)
 {
    x86_setup_mtrrs_with_detect();
@@ -906,7 +908,6 @@
    .read_resources	  = noop_read_resources,
    .set_resources	  = noop_set_resources,
    .init		  = mp_cpu_bus_init,
-	.scan_bus	  = cpu_bus_scan,
 };

static void root_complex_enable_dev(struct device *dev)