[S] Change in coreboot[main]: vc/amd/opensil/genoa_poc/mpio: add ENGINE_ prefix to mpio_type values - coreboot-gerrit

19 Mar 2024


      Attention is currently required from: Martin L Roth.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81338?usp=email )
Change subject: vc/amd/opensil/genoa_poc/mpio: add ENGINE_ prefix to mpio_type values
......................................................................
Patch Set 2:
(1 comment)
File src/vendorcode/amd/opensil/genoa_poc/mpio/chip.h:
https://review.coreboot.org/c/coreboot/+/81338/comment/c2e4f686_f4e87ba1 :
PS2, Line 20: ENGINE_PCIE
...
These are getting renamed away from "engine" internally. […]
MUX_TYPE doesn't make much sense to me in this context; Matt suggested using IFTYPE_PCIE as prefix which sounds good to me
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/81338?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I229a3402c36941ee5347e3704fcf8d8a1bbc78a6
Gerrit-Change-Number: 81338
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Comment-Date: Tue, 19 Mar 2024 16:24:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth gaumless@gmail.com
Gerrit-MessageType: comment