Change in coreboot[master]: src/lib/prog_loaders: Add preload_ramstage - coreboot-gerrit

15 Nov 2021


      Attention is currently required from: Martin Roth, Julius Werner, Rob Barnes.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58982 )
Change subject: src/lib/prog_loaders: Add preload_ramstage
......................................................................
Patch Set 3:
(1 comment)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/58982/comment/3cb49b9d_84153c7b 
PS3, Line 1219: $(CONFIG_CBFS_PREFIX)/ramstage-align := 64
...
Should there be an else block here? i.e. […]
`ramstage-align` is not set in that case. This leaves leaves it up to CBFS to best decide where to place it. I'm not actually sure what the min-alignment in CBFS is, but I'm guessing 8 bytes.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58982
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe12de806449da25bc0033b02fcb97c3384eddc1
Gerrit-Change-Number: 58982
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi patrick@coreboot.org
Gerrit-Reviewer: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Rob Barnes robbarnes@google.com
Gerrit-Comment-Date: Mon, 15 Nov 2021 16:00:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rob Barnes robbarnes@google.com
Gerrit-MessageType: comment