Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/29549 )
Change subject: siemens/mc_apl3: Disable PCI clock outputs on XIO bridges ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/29549/4/src/mainboard/siemens/mc_apl1/varian... File src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c:
https://review.coreboot.org/#/c/29549/4/src/mainboard/siemens/mc_apl1/varian... PS4, Line 73: dev->bus->dev->device
So do you need dev->bus->dev->device or dev->device which is used in the upper case?
In the above case, I set the parent device before the if instruction to dev object (line 64). Because of the 80 character rule, the if instruction is then better readable. In the second case, I don't take the intermediate step.
-
Mario Scheithauer (Code Review)