Attention is currently required from: Tarun Tuli, Subrata Banik, Caveh Jalali, Nick Vaccaro, Daisuke Nojiri, Eric Lai, Boris Mittelberg.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70773 )
Change subject: src/mainboard/brya/: Clear EC AP_IDLE flag after shutdown
......................................................................
Patch Set 11:
(1 comment)
File src/mainboard/google/brya/mainboard.c:
https://review.coreboot.org/c/coreboot/+/70773/comment/d692ecc5_e236bf36
PS11, Line 219: if (CONFIG(CR50_RESET_CLEAR_EC_AP_IDLE_FLAG)) {
I think you can add in here https://source.chromium. […]
It is required for all Chromebox/base if POWER_OFF_ON_CR50_UPDATE is enabled, so I prefer to add it in https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70773
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If97ffbe65f4783f17f4747a87b0bf89a2b021a3b
Gerrit-Change-Number: 70773
Gerrit-PatchSet: 11
Gerrit-Owner: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Tue, 03 Jan 2023 06:36:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment