Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/57669 )
Change subject: soc/intel/denverton_ns: Always enable SpeedStep ......................................................................
soc/intel/denverton_ns: Always enable SpeedStep
When "SpeedStep" is disabled on an Intel Atom C3538, the maximum CPU clock speed is always 800 MHz(min CPU clock). Оperating system cannot change the frequency. Avoid this issue allow "Intel Speed step" technology for processors that do not have "Intel Turbo Boost".
Signed-off-by: Dmitry Ponamorev dponamorev@gmail.com Change-Id: Ia922e45c12e4239f1d59617193cdbde2a813e7d0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/57669 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Werner Zeh werner.zeh@siemens.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: King Sumo kingsumos@gmail.com --- M src/soc/intel/denverton_ns/cpu.c 1 file changed, 4 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Werner Zeh: Looks good to me, approved Angel Pons: Looks good to me, approved King Sumo: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/denverton_ns/cpu.c b/src/soc/intel/denverton_ns/cpu.c index 10e79be..95f164d 100644 --- a/src/soc/intel/denverton_ns/cpu.c +++ b/src/soc/intel/denverton_ns/cpu.c @@ -90,12 +90,10 @@ /* Enable Turbo */ enable_turbo();
- /* Enable speed step. */ - if (get_turbo_state() == TURBO_ENABLED) { - msr = rdmsr(IA32_MISC_ENABLE); - msr.lo |= SPEED_STEP_ENABLE_BIT; - wrmsr(IA32_MISC_ENABLE, msr); - } + /* Enable speed step. Always ON.*/ + msr = rdmsr(IA32_MISC_ENABLE); + msr.lo |= SPEED_STEP_ENABLE_BIT; + wrmsr(IA32_MISC_ENABLE, msr); }
static struct device_operations cpu_dev_ops = {