[M] Change in coreboot[master]: mb/google/nissa/var/yaviks: Disable external fivr - coreboot-gerrit

4 Jan 2023


      Attention is currently required from: Tarun Tuli, Kangheui Won, Chen Wisley, Paul Menzel, Reka Norman, Eric Lai, Shou-Chieh Hsu.
Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71560 )
Change subject: mb/google/nissa/var/yaviks: Disable external fivr
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/google/brya/variants/yaviks/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/71560/comment/a526e5e0_2ff92fd9 
PS8, Line 26: 		.configure_ext_fivr = 1,
...
Should we also set this to 0?
In the cb*66863's comment, mentioned that "Follow Intel suggest, and other project of doesn't have V1p05 and Vnn also keep this, ex: brya0" .
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/71560
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id85570046c5b8e9d90a112793c1ec8604e6bf533
Gerrit-Change-Number: 71560
Gerrit-PatchSet: 8
Gerrit-Owner: Chen Wisley wisley.chen%quantatw.com@gtempaccount.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Reka Norman rekanorman@chromium.org
Gerrit-Reviewer: Shou-Chieh Hsu shouchieh@google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: Wisley Chen wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Kangheui Won khwon@chromium.org
Gerrit-Attention: Chen Wisley wisley.chen%quantatw.com@gtempaccount.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Reka Norman rekanorman@chromium.org
Gerrit-Attention: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Shou-Chieh Hsu shouchieh@google.com
Gerrit-Comment-Date: Wed, 04 Jan 2023 01:36:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kangheui Won khwon@chromium.org
Gerrit-MessageType: comment