Evgeny Zinoviev has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32683
Change subject: util/autoport: Add info about rank_mirror to readme.md ......................................................................
util/autoport: Add info about rank_mirror to readme.md
inteltool can't detect whether address mapping is normal or mirrored, which in turn may be cause RAM initialization to fail when using spd.bin generated by inteltool.
Mention this in readme as it may help someone.
Change-Id: I8d24e4d9332bdcf484987581dd6941e2bf9c4f87 Signed-off-by: Evgeny Zinoviev me@ch1p.io --- M util/autoport/readme.md 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/32683/1
diff --git a/util/autoport/readme.md b/util/autoport/readme.md index 4683d8d..6e0a7ef 100644 --- a/util/autoport/readme.md +++ b/util/autoport/readme.md @@ -267,6 +267,10 @@ not forget to copy the data on all the array elements that need it. * If they use different data, use several files.
+If memory initialization is not working, try enbling rank_mirror, which can't +be detected by inteltool. To do that, set the lowest bit at the offset `0x3f` +in `spd.bin` to 1. + ### `board_info.txt`
`board_info.txt` is a text file used in the board status page to list all
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32683 )
Change subject: util/autoport: Add info about rank_mirror to readme.md ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/32683/1/util/autoport/readme.md File util/autoport/readme.md:
https://review.coreboot.org/#/c/32683/1/util/autoport/readme.md@270 PS1, Line 270: If memory initialization is not working, try enbling rank_mirror, which can't Please add "in particular write training (timB) on DIMM's second rank fails" or something similar
https://review.coreboot.org/#/c/32683/1/util/autoport/readme.md@272 PS1, Line 272: in `spd.bin` to 1. Please mention the name of the SPD register and bit.
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32683
to look at the new patch set (#2).
Change subject: util/autoport: Add info about rank 1 mirroring ......................................................................
util/autoport: Add info about rank 1 mirroring
inteltool can't detect whether address mapping is normal or mirrored, which in turn may be cause RAM initialization to fail when using spd.bin generated by inteltool.
Mention this in readme as it may help someone.
Change-Id: I8d24e4d9332bdcf484987581dd6941e2bf9c4f87 Signed-off-by: Evgeny Zinoviev me@ch1p.io --- M util/autoport/readme.md 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/32683/2
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32683
to look at the new patch set (#3).
Change subject: util/autoport: Add info about rank 1 mirroring ......................................................................
util/autoport: Add info about rank 1 mirroring
inteltool can't detect whether address mapping is normal or mirrored, which in turn may be cause RAM initialization to fail when using spd.bin generated by inteltool.
Mention this in readme as it may help someone.
Change-Id: I8d24e4d9332bdcf484987581dd6941e2bf9c4f87 Signed-off-by: Evgeny Zinoviev me@ch1p.io --- M util/autoport/readme.md 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/32683/3
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32683 )
Change subject: util/autoport: Add info about rank 1 mirroring ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/32683/1/util/autoport/readme.md File util/autoport/readme.md:
https://review.coreboot.org/#/c/32683/1/util/autoport/readme.md@270 PS1, Line 270: If memory initialization is not working, try enbling rank_mirror, which can't
Please add "in particular write training (timB) on DIMM's second rank fails" or something similar
Done
https://review.coreboot.org/#/c/32683/1/util/autoport/readme.md@272 PS1, Line 272: in `spd.bin` to 1.
Please mention the name of the SPD register and bit.
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32683 )
Change subject: util/autoport: Add info about rank 1 mirroring ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32683 )
Change subject: util/autoport: Add info about rank 1 mirroring ......................................................................
util/autoport: Add info about rank 1 mirroring
inteltool can't detect whether address mapping is normal or mirrored, which in turn may be cause RAM initialization to fail when using spd.bin generated by inteltool.
Mention this in readme as it may help someone.
Change-Id: I8d24e4d9332bdcf484987581dd6941e2bf9c4f87 Signed-off-by: Evgeny Zinoviev me@ch1p.io Reviewed-on: https://review.coreboot.org/c/coreboot/+/32683 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M util/autoport/readme.md 1 file changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/util/autoport/readme.md b/util/autoport/readme.md index cfa8c36..fa349b9 100644 --- a/util/autoport/readme.md +++ b/util/autoport/readme.md @@ -268,6 +268,12 @@ not forget to copy the data on all the array elements that need it. * If they use different data, use several files.
+If memory initialization is not working, in particular write training (timB) +on DIMM's second rank fails, try enbling rank 1 mirroring, which can't be +detected by inteltool. It is described by SPD field "Address Mapping from Edge +Connector to DRAM", byte `63` (`0x3f`). Bit 0 describes Rank 1 Mapping, +0 = standard, 1 = mirrored; set it to 1. Bits 1-7 are reserved. + ### `board_info.txt`
`board_info.txt` is a text file used in the board status page to list all
-
Angel Pons (Code Review) -
Evgeny Zinoviev (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)