Attention is currently required from: Sean Rhodes.
Subrata Banik has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84133?usp=email )
Change subject: drivers/usb/acpi: Add DSM for Intel Bluetooth ......................................................................
Patch Set 3:
(4 comments)
File src/drivers/usb/acpi/chip.h:
https://review.coreboot.org/c/coreboot/+/84133/comment/edd28b1d_e883830c?usp... : PS3, Line 51: bool intel_bt; can you please use a meaningful name ? I don't understand what you mean by `intel_bt` ? is it like `is_bt_vendor_intel`?
File src/drivers/usb/acpi/usb_acpi.c:
https://review.coreboot.org/c/coreboot/+/84133/comment/62a3288e_7c155c2f?usp... : PS3, Line 12: just one space to start the comment
https://review.coreboot.org/c/coreboot/+/84133/comment/852daf8f_83a617cc?usp... : PS3, Line 27: 0x03 can you please explain the meaning of hard coded value ?
https://review.coreboot.org/c/coreboot/+/84133/comment/cedc4416_5fdf9930?usp... : PS3, Line 36: /* aa10f4e0-81ac-4233-abf6-3b2ac50e28d9 */ unable to follow why you have used the GUID here ?